From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Alberto Escudero-Pascual <aep@it46.se>
Subject: Re: [B.A.T.M.A.N.] [Patch] vis: Modified format of JSON output.
Date: Wed, 9 Mar 2011 18:04:50 +0100 [thread overview]
Message-ID: <201103091804.55424.sven@narfation.org> (raw)
In-Reply-To: <201103091748.32512.onelektra@gmx.net>
[-- Attachment #1: Type: Text/Plain, Size: 736 bytes --]
On Wednesday 09 March 2011 17:48:32 elektra wrote:
> The current vis server JSON output format is breaking the json_decode()
> function for PHP.
>
> This patch mainly:
> - Removes all spaces
> - Removes all the \t TABS
> - Double quotes the string-variables
>
> Reported-by: "Alberto Escudero-Pascual" <aep@it46.se>
> Signed-off-by: "elektra" <onelektra@gmx.net>
I am not sure if anyone currently maintains batmand and vis.
Anyway, your patch is more or less scrambled. Can you please resend it using a
client which doesn't create a wordwrap and space massacre[1]. Many people here
seem to use git-send-email for that purpose.
Kind regards,
Sven
[1] http://kernel.org/doc/Documentation/email-clients.txt
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-03-09 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 16:48 [B.A.T.M.A.N.] [Patch] vis: Modified format of JSON output elektra
2011-03-09 17:04 ` Sven Eckelmann [this message]
2011-03-10 7:55 ` Alberto Escudero-Pascual
2011-03-10 8:28 ` Marek Lindner
-- strict thread matches above, loose matches on Subject: below --
2011-03-09 17:16 elektra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103091804.55424.sven@narfation.org \
--to=sven@narfation.org \
--cc=aep@it46.se \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.