* [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
@ 2011-03-09 20:50 Vinay Sawal
2011-03-09 20:55 ` Belisko Marek
2011-03-09 21:26 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Vinay Sawal @ 2011-03-09 20:50 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Vinay Sawal
Fixed all issues reported by checkpatch script on this file.
Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
---
drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
1 files changed, 36 insertions(+), 15 deletions(-)
diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
index a6ce239..4e38a76 100644
--- a/drivers/staging/bcm/Bcmnet.c
+++ b/drivers/staging/bcm/Bcmnet.c
@@ -1,3 +1,23 @@
+/*
+ bcm/Bcmnet.c
+ Bcm network driver
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 2 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program; if not, write to the Free Software
+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+
+*/
+
#include "headers.h"
struct net_device *gblpnetdev;
@@ -8,7 +28,7 @@ static INT bcm_open(struct net_device *dev)
if (Adapter->fw_download_done == FALSE) {
pr_notice(PFX "%s: link up failed (download in progress)\n",
- dev->name);
+ dev->name);
return -EBUSY;
}
@@ -50,7 +70,7 @@ static u16 bcm_select_queue(struct net_device *dev, struct sk_buff *skb)
* Description - This is the main transmit function for our virtual
* interface(eth0). It handles the ARP packets. It
* clones this packet and then Queue it to a suitable
-* Queue. Then calls the transmit_packet().
+* Queue. Then calls the transmit_packet().
*
* Parameter - skb - Pointer to the socket buffer structure
* dev - Pointer to the virtual net device structure
@@ -110,13 +130,13 @@ static netdev_tx_t bcm_transmit(struct sk_buff *skb, struct net_device *dev)
Register other driver entry points with the kernel
*/
static const struct net_device_ops bcmNetDevOps = {
- .ndo_open = bcm_open,
- .ndo_stop = bcm_close,
- .ndo_start_xmit = bcm_transmit,
- .ndo_change_mtu = eth_change_mtu,
- .ndo_set_mac_address = eth_mac_addr,
- .ndo_validate_addr = eth_validate_addr,
- .ndo_select_queue = bcm_select_queue,
+ .ndo_open = bcm_open,
+ .ndo_stop = bcm_close,
+ .ndo_start_xmit = bcm_transmit,
+ .ndo_change_mtu = eth_change_mtu,
+ .ndo_set_mac_address = eth_mac_addr,
+ .ndo_validate_addr = eth_validate_addr,
+ .ndo_select_queue = bcm_select_queue,
};
static struct device_type wimax_type = {
@@ -138,7 +158,8 @@ static int bcm_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
return 0;
}
-static void bcm_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
+static void bcm_get_drvinfo(struct net_device *dev,
+ struct ethtool_drvinfo *info)
{
PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
PS_INTERFACE_ADAPTER psIntfAdapter = Adapter->pvInterfaceAdapter;
@@ -160,14 +181,14 @@ static u32 bcm_get_link(struct net_device *dev)
return Adapter->LinkUpStatus;
}
-static u32 bcm_get_msglevel (struct net_device *dev)
+static u32 bcm_get_msglevel(struct net_device *dev)
{
PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
return Adapter->msg_enable;
}
-static void bcm_set_msglevel (struct net_device *dev, u32 level)
+static void bcm_set_msglevel(struct net_device *dev, u32 level)
{
PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
@@ -177,7 +198,7 @@ static void bcm_set_msglevel (struct net_device *dev, u32 level)
static const struct ethtool_ops bcm_ethtool_ops = {
.get_settings = bcm_get_settings,
.get_drvinfo = bcm_get_drvinfo,
- .get_link = bcm_get_link,
+ .get_link = bcm_get_link,
.get_msglevel = bcm_get_msglevel,
.set_msglevel = bcm_set_msglevel,
};
@@ -206,7 +227,7 @@ int register_networkdev(PMINI_ADAPTER Adapter)
if (result != STATUS_SUCCESS) {
dev_err(&udev->dev,
PFX "Error in Reading the mac Address: %d", result);
- return -EIO;
+ return -EIO;
}
result = register_netdev(net);
@@ -233,6 +254,6 @@ void unregister_networkdev(PMINI_ADAPTER Adapter)
if (netif_msg_probe(Adapter))
dev_info(&udev->dev, PFX "%s: unregister usb-%s%s\n",
net->name, xdev->bus->bus_name, xdev->devpath);
-
+
unregister_netdev(Adapter->dev);
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
2011-03-09 20:50 [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues Vinay Sawal
@ 2011-03-09 20:55 ` Belisko Marek
2011-03-09 21:21 ` Vinay Sawal
2011-03-09 21:26 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Belisko Marek @ 2011-03-09 20:55 UTC (permalink / raw)
To: Vinay Sawal; +Cc: gregkh, devel, linux-kernel
On Wed, Mar 9, 2011 at 9:50 PM, Vinay Sawal <vinaysawal@gmail.com> wrote:
> Fixed all issues reported by checkpatch script on this file.
>
> Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
> ---
> drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
> 1 files changed, 36 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
> index a6ce239..4e38a76 100644
> --- a/drivers/staging/bcm/Bcmnet.c
> +++ b/drivers/staging/bcm/Bcmnet.c
> @@ -1,3 +1,23 @@
> +/*
> + bcm/Bcmnet.c
> + Bcm network driver
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 2 of the License, or
> + (at your option) any later version.
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software
> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
> +
> +*/
NOt sure if I miss somethoing but why you add header
if you fix only checkpatch.pl fixes? I don't know that
checkpatch.pl complain about missing header file?
> +
> #include "headers.h"
>
> struct net_device *gblpnetdev;
> @@ -8,7 +28,7 @@ static INT bcm_open(struct net_device *dev)
>
> if (Adapter->fw_download_done == FALSE) {
> pr_notice(PFX "%s: link up failed (download in progress)\n",
> - dev->name);
> + dev->name);
> return -EBUSY;
> }
>
> @@ -50,7 +70,7 @@ static u16 bcm_select_queue(struct net_device *dev, struct sk_buff *skb)
> * Description - This is the main transmit function for our virtual
> * interface(eth0). It handles the ARP packets. It
> * clones this packet and then Queue it to a suitable
> -* Queue. Then calls the transmit_packet().
> +* Queue. Then calls the transmit_packet().
> *
> * Parameter - skb - Pointer to the socket buffer structure
> * dev - Pointer to the virtual net device structure
> @@ -110,13 +130,13 @@ static netdev_tx_t bcm_transmit(struct sk_buff *skb, struct net_device *dev)
> Register other driver entry points with the kernel
> */
> static const struct net_device_ops bcmNetDevOps = {
> - .ndo_open = bcm_open,
> - .ndo_stop = bcm_close,
> - .ndo_start_xmit = bcm_transmit,
> - .ndo_change_mtu = eth_change_mtu,
> - .ndo_set_mac_address = eth_mac_addr,
> - .ndo_validate_addr = eth_validate_addr,
> - .ndo_select_queue = bcm_select_queue,
> + .ndo_open = bcm_open,
> + .ndo_stop = bcm_close,
> + .ndo_start_xmit = bcm_transmit,
> + .ndo_change_mtu = eth_change_mtu,
> + .ndo_set_mac_address = eth_mac_addr,
> + .ndo_validate_addr = eth_validate_addr,
> + .ndo_select_queue = bcm_select_queue,
> };
>
> static struct device_type wimax_type = {
> @@ -138,7 +158,8 @@ static int bcm_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
> return 0;
> }
>
> -static void bcm_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
> +static void bcm_get_drvinfo(struct net_device *dev,
> + struct ethtool_drvinfo *info)
> {
> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
> PS_INTERFACE_ADAPTER psIntfAdapter = Adapter->pvInterfaceAdapter;
> @@ -160,14 +181,14 @@ static u32 bcm_get_link(struct net_device *dev)
> return Adapter->LinkUpStatus;
> }
>
> -static u32 bcm_get_msglevel (struct net_device *dev)
> +static u32 bcm_get_msglevel(struct net_device *dev)
> {
> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>
> return Adapter->msg_enable;
> }
>
> -static void bcm_set_msglevel (struct net_device *dev, u32 level)
> +static void bcm_set_msglevel(struct net_device *dev, u32 level)
> {
> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>
> @@ -177,7 +198,7 @@ static void bcm_set_msglevel (struct net_device *dev, u32 level)
> static const struct ethtool_ops bcm_ethtool_ops = {
> .get_settings = bcm_get_settings,
> .get_drvinfo = bcm_get_drvinfo,
> - .get_link = bcm_get_link,
> + .get_link = bcm_get_link,
> .get_msglevel = bcm_get_msglevel,
> .set_msglevel = bcm_set_msglevel,
> };
> @@ -206,7 +227,7 @@ int register_networkdev(PMINI_ADAPTER Adapter)
> if (result != STATUS_SUCCESS) {
> dev_err(&udev->dev,
> PFX "Error in Reading the mac Address: %d", result);
> - return -EIO;
> + return -EIO;
> }
>
> result = register_netdev(net);
> @@ -233,6 +254,6 @@ void unregister_networkdev(PMINI_ADAPTER Adapter)
> if (netif_msg_probe(Adapter))
> dev_info(&udev->dev, PFX "%s: unregister usb-%s%s\n",
> net->name, xdev->bus->bus_name, xdev->devpath);
> -
> +
> unregister_netdev(Adapter->dev);
> }
> --
> 1.6.2.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
thanks,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
2011-03-09 20:55 ` Belisko Marek
@ 2011-03-09 21:21 ` Vinay Sawal
2011-03-09 21:40 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Vinay Sawal @ 2011-03-09 21:21 UTC (permalink / raw)
To: Belisko Marek; +Cc: gregkh, devel, linux-kernel
On Wed, Mar 9, 2011 at 12:55 PM, Belisko Marek <marek.belisko@gmail.com> wrote:
> On Wed, Mar 9, 2011 at 9:50 PM, Vinay Sawal <vinaysawal@gmail.com> wrote:
>> Fixed all issues reported by checkpatch script on this file.
>>
>> Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
>> ---
>> drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
>> 1 files changed, 36 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
>> index a6ce239..4e38a76 100644
>> --- a/drivers/staging/bcm/Bcmnet.c
>> +++ b/drivers/staging/bcm/Bcmnet.c
>> @@ -1,3 +1,23 @@
>> +/*
>> + bcm/Bcmnet.c
>> + Bcm network driver
>> +
>> + This program is free software; you can redistribute it and/or modify
>> + it under the terms of the GNU General Public License as published by
>> + the Free Software Foundation; either version 2 of the License, or
>> + (at your option) any later version.
>> +
>> + This program is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + GNU General Public License for more details.
>> +
>> + You should have received a copy of the GNU General Public License
>> + along with this program; if not, write to the Free Software
>> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>> +
>> +*/
> NOt sure if I miss somethoing but why you add header
> if you fix only checkpatch.pl fixes? I don't know that
> checkpatch.pl complain about missing header file?
You're correct. The script checkpatch didn't complain about the
missing license header. But since the license header was missing, I
added it. I should have listed it in the patch comments.
Isn't it a requirement to have the GPL license header in every file ?
If true, maybe the script can be enhanced to check for missing license
header.
Thanks,
Vinay
>> +
>> #include "headers.h"
>>
>> struct net_device *gblpnetdev;
>> @@ -8,7 +28,7 @@ static INT bcm_open(struct net_device *dev)
>>
>> if (Adapter->fw_download_done == FALSE) {
>> pr_notice(PFX "%s: link up failed (download in progress)\n",
>> - dev->name);
>> + dev->name);
>> return -EBUSY;
>> }
>>
>> @@ -50,7 +70,7 @@ static u16 bcm_select_queue(struct net_device *dev, struct sk_buff *skb)
>> * Description - This is the main transmit function for our virtual
>> * interface(eth0). It handles the ARP packets. It
>> * clones this packet and then Queue it to a suitable
>> -* Queue. Then calls the transmit_packet().
>> +* Queue. Then calls the transmit_packet().
>> *
>> * Parameter - skb - Pointer to the socket buffer structure
>> * dev - Pointer to the virtual net device structure
>> @@ -110,13 +130,13 @@ static netdev_tx_t bcm_transmit(struct sk_buff *skb, struct net_device *dev)
>> Register other driver entry points with the kernel
>> */
>> static const struct net_device_ops bcmNetDevOps = {
>> - .ndo_open = bcm_open,
>> - .ndo_stop = bcm_close,
>> - .ndo_start_xmit = bcm_transmit,
>> - .ndo_change_mtu = eth_change_mtu,
>> - .ndo_set_mac_address = eth_mac_addr,
>> - .ndo_validate_addr = eth_validate_addr,
>> - .ndo_select_queue = bcm_select_queue,
>> + .ndo_open = bcm_open,
>> + .ndo_stop = bcm_close,
>> + .ndo_start_xmit = bcm_transmit,
>> + .ndo_change_mtu = eth_change_mtu,
>> + .ndo_set_mac_address = eth_mac_addr,
>> + .ndo_validate_addr = eth_validate_addr,
>> + .ndo_select_queue = bcm_select_queue,
>> };
>>
>> static struct device_type wimax_type = {
>> @@ -138,7 +158,8 @@ static int bcm_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
>> return 0;
>> }
>>
>> -static void bcm_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info)
>> +static void bcm_get_drvinfo(struct net_device *dev,
>> + struct ethtool_drvinfo *info)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>> PS_INTERFACE_ADAPTER psIntfAdapter = Adapter->pvInterfaceAdapter;
>> @@ -160,14 +181,14 @@ static u32 bcm_get_link(struct net_device *dev)
>> return Adapter->LinkUpStatus;
>> }
>>
>> -static u32 bcm_get_msglevel (struct net_device *dev)
>> +static u32 bcm_get_msglevel(struct net_device *dev)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>>
>> return Adapter->msg_enable;
>> }
>>
>> -static void bcm_set_msglevel (struct net_device *dev, u32 level)
>> +static void bcm_set_msglevel(struct net_device *dev, u32 level)
>> {
>> PMINI_ADAPTER Adapter = GET_BCM_ADAPTER(dev);
>>
>> @@ -177,7 +198,7 @@ static void bcm_set_msglevel (struct net_device *dev, u32 level)
>> static const struct ethtool_ops bcm_ethtool_ops = {
>> .get_settings = bcm_get_settings,
>> .get_drvinfo = bcm_get_drvinfo,
>> - .get_link = bcm_get_link,
>> + .get_link = bcm_get_link,
>> .get_msglevel = bcm_get_msglevel,
>> .set_msglevel = bcm_set_msglevel,
>> };
>> @@ -206,7 +227,7 @@ int register_networkdev(PMINI_ADAPTER Adapter)
>> if (result != STATUS_SUCCESS) {
>> dev_err(&udev->dev,
>> PFX "Error in Reading the mac Address: %d", result);
>> - return -EIO;
>> + return -EIO;
>> }
>>
>> result = register_netdev(net);
>> @@ -233,6 +254,6 @@ void unregister_networkdev(PMINI_ADAPTER Adapter)
>> if (netif_msg_probe(Adapter))
>> dev_info(&udev->dev, PFX "%s: unregister usb-%s%s\n",
>> net->name, xdev->bus->bus_name, xdev->devpath);
>> -
>> +
>> unregister_netdev(Adapter->dev);
>> }
>> --
>> 1.6.2.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>>
>
> thanks,
>
> marek
>
> --
> as simple and primitive as possible
> -------------------------------------------------
> Marek Belisko - OPEN-NANDRA
> Freelance Developer
>
> Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
> Tel: +421 915 052 184
> skype: marekwhite
> icq: 290551086
> web: http://open-nandra.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
2011-03-09 20:50 [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues Vinay Sawal
2011-03-09 20:55 ` Belisko Marek
@ 2011-03-09 21:26 ` Greg KH
2011-03-09 21:34 ` Vinay Sawal
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2011-03-09 21:26 UTC (permalink / raw)
To: Vinay Sawal; +Cc: devel, linux-kernel
On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote:
> Fixed all issues reported by checkpatch script on this file.
>
> Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
> ---
> drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
> 1 files changed, 36 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
> index a6ce239..4e38a76 100644
> --- a/drivers/staging/bcm/Bcmnet.c
> +++ b/drivers/staging/bcm/Bcmnet.c
> @@ -1,3 +1,23 @@
> +/*
> + bcm/Bcmnet.c
> + Bcm network driver
> +
> + This program is free software; you can redistribute it and/or modify
> + it under the terms of the GNU General Public License as published by
> + the Free Software Foundation; either version 2 of the License, or
> + (at your option) any later version.
Why "or any later version"? Are you allowed to relicense the code here?
> +
> + This program is distributed in the hope that it will be useful,
> + but WITHOUT ANY WARRANTY; without even the implied warranty of
> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + GNU General Public License for more details.
> +
> + You should have received a copy of the GNU General Public License
> + along with this program; if not, write to the Free Software
> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
Are you willing to track the office movements of the FSF for the next 40
years and send patches updating the address? If not, NEVER, include
this paragraph, it's pointless.
Anyway, as others stated, this is not acceptable for a "fix checkpatch
warnings" type of patch, please redo it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
2011-03-09 21:26 ` Greg KH
@ 2011-03-09 21:34 ` Vinay Sawal
0 siblings, 0 replies; 6+ messages in thread
From: Vinay Sawal @ 2011-03-09 21:34 UTC (permalink / raw)
To: Greg KH; +Cc: devel, linux-kernel
On Wed, Mar 9, 2011 at 1:26 PM, Greg KH <gregkh@suse.de> wrote:
> On Wed, Mar 09, 2011 at 12:50:01PM -0800, Vinay Sawal wrote:
>> Fixed all issues reported by checkpatch script on this file.
>>
>> Signed-off-by: Vinay Sawal <vinaysawal@gmail.com>
>> ---
>> drivers/staging/bcm/Bcmnet.c | 51 +++++++++++++++++++++++++++++------------
>> 1 files changed, 36 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/staging/bcm/Bcmnet.c b/drivers/staging/bcm/Bcmnet.c
>> index a6ce239..4e38a76 100644
>> --- a/drivers/staging/bcm/Bcmnet.c
>> +++ b/drivers/staging/bcm/Bcmnet.c
>> @@ -1,3 +1,23 @@
>> +/*
>> + bcm/Bcmnet.c
>> + Bcm network driver
>> +
>> + This program is free software; you can redistribute it and/or modify
>> + it under the terms of the GNU General Public License as published by
>> + the Free Software Foundation; either version 2 of the License, or
>> + (at your option) any later version.
>
> Why "or any later version"? Are you allowed to relicense the code here?
>
>> +
>> + This program is distributed in the hope that it will be useful,
>> + but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + GNU General Public License for more details.
>> +
>> + You should have received a copy of the GNU General Public License
>> + along with this program; if not, write to the Free Software
>> + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>
> Are you willing to track the office movements of the FSF for the next 40
> years and send patches updating the address? If not, NEVER, include
> this paragraph, it's pointless.
>
> Anyway, as others stated, this is not acceptable for a "fix checkpatch
> warnings" type of patch, please redo it.
Fair point. I'll re-generate the patch.
thanks,
vinay
>
> thanks,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
2011-03-09 21:21 ` Vinay Sawal
@ 2011-03-09 21:40 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2011-03-09 21:40 UTC (permalink / raw)
To: Vinay Sawal; +Cc: Belisko Marek, devel, linux-kernel
On Wed, Mar 09, 2011 at 01:21:28PM -0800, Vinay Sawal wrote:
> You're correct. The script checkpatch didn't complain about the
> missing license header.
Where did you get that license header from? Are you sure you were
allowed to license the code in that specific way?
> But since the license header was missing, I
> added it. I should have listed it in the patch comments.
No, you should have done it in a separate patch, if you do that.
Remember, one patch per "thing you do" is the rule.
> Isn't it a requirement to have the GPL license header in every file ?
No.
> If true, maybe the script can be enhanced to check for missing license
> header.
That's not true, the overall license of the kernel covers the license of
the file, if not explicitly stated. And you were stating that the
license of this file is _different_ from the license of the kernel
overall, so you had better have the legal right to be doing that. Do
you?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-09 21:41 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 20:50 [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues Vinay Sawal
2011-03-09 20:55 ` Belisko Marek
2011-03-09 21:21 ` Vinay Sawal
2011-03-09 21:40 ` Greg KH
2011-03-09 21:26 ` Greg KH
2011-03-09 21:34 ` Vinay Sawal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.