From: Greg KH <gregkh@suse.de>
To: Vinay Sawal <vinaysawal@gmail.com>
Cc: Belisko Marek <marek.belisko@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues
Date: Wed, 9 Mar 2011 13:40:56 -0800 [thread overview]
Message-ID: <20110309214056.GA28036@suse.de> (raw)
In-Reply-To: <AANLkTi==5jKHwTEhh1xE7_7-a7JHbaNWOdOKHFFdz0Wc@mail.gmail.com>
On Wed, Mar 09, 2011 at 01:21:28PM -0800, Vinay Sawal wrote:
> You're correct. The script checkpatch didn't complain about the
> missing license header.
Where did you get that license header from? Are you sure you were
allowed to license the code in that specific way?
> But since the license header was missing, I
> added it. I should have listed it in the patch comments.
No, you should have done it in a separate patch, if you do that.
Remember, one patch per "thing you do" is the rule.
> Isn't it a requirement to have the GPL license header in every file ?
No.
> If true, maybe the script can be enhanced to check for missing license
> header.
That's not true, the overall license of the kernel covers the license of
the file, if not explicitly stated. And you were stating that the
license of this file is _different_ from the license of the kernel
overall, so you had better have the legal right to be doing that. Do
you?
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-09 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 20:50 [PATCH] Staging: bcm: Bcmnet: fixed checkpatch script issues Vinay Sawal
2011-03-09 20:55 ` Belisko Marek
2011-03-09 21:21 ` Vinay Sawal
2011-03-09 21:40 ` Greg KH [this message]
2011-03-09 21:26 ` Greg KH
2011-03-09 21:34 ` Vinay Sawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309214056.GA28036@suse.de \
--to=gregkh@suse.de \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@gmail.com \
--cc=vinaysawal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.