All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: dbrownell@users.sourceforge.net, gregkh@suse.de,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb-gadget: unlock data->lock mutex on error path in ep_read()
Date: Wed, 9 Mar 2011 15:39:46 -0800	[thread overview]
Message-ID: <20110309233946.GA31857@kroah.com> (raw)
In-Reply-To: <4D772F2B.6030209@ispras.ru>

On Wed, Mar 09, 2011 at 10:41:31AM +0300, Alexey Khoroshilov wrote:
> ep_read() acquires data->lock mutex in get_ready_ep() and releases it on
> all paths except for one: when usb_endpoint_xfer_isoc() failed. The
> patch adds mutex_unlock(&data->lock) at that path.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov<khoroshilov@ispras.ru>

Need a space after your name and before the email address.

Anyway, your patch is still line-wrapped and the leading spaces stripped
off, making it impossible to apply.  After hand-editing it, it still
fails, are you sure you made this against the linux-next tree?

Care to try again?

thanks,

greg k-h

  reply	other threads:[~2011-03-09 23:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09  7:41 [PATCH] usb-gadget: unlock data->lock mutex on error path in ep_read() Alexey Khoroshilov
2011-03-09 23:39 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-03-04 22:54 Alexey Khoroshilov
2011-03-07 20:13 ` Greg KH
2011-03-09  7:43   ` Alexey Khoroshilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110309233946.GA31857@kroah.com \
    --to=greg@kroah.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=gregkh@suse.de \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.