From: Greg KH <greg@kroah.com>
To: Marek Belisko <marek.belisko@open-nandra.com>
Cc: gregkh@suse.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/21] Coding style and minor changes in ft1000_hw.
Date: Wed, 9 Mar 2011 16:00:22 -0800 [thread overview]
Message-ID: <20110310000022.GA17741@kroah.com> (raw)
In-Reply-To: <1299486086-7325-1-git-send-email-marek.belisko@open-nandra.com>
On Mon, Mar 07, 2011 at 09:21:05AM +0100, Marek Belisko wrote:
> Marek Belisko (21):
> staging: ft1000: Replace camelcase CardSendCommand function name.
> staging: ft1000: Fix coding style in card_send_command function.
> staging: ft1000: Fix coding style in dsp_reload function.
> staging: ft1000: Fix coding style in ft1000_reset_asic function.
> staging: ft1000: Fix coding style in ft1000_reset_card function.
> staging: ft1000: Fix identation in ftnet_ops struct.
> staging: ft1000: Fix coding style in init_ft1000_netdev function.
> staging: ft1000: Change return value for init_ft1000_netdev function.
> staging: ft1000: Fix coding style in reg_ft1000_netdev function.
> staging: ft1000: Fix coding style in ft1000_reset function.
> staging: ft1000: Fix coding style in ft1000_usb_transmit_complete
> function.
> staging: ft1000: Fix coding style in ft1000_copy_down_pkt function.
> staging: ft1000: Fix coding style in ft1000_start_xmit function.
> staging: ft1000: Fix coding style in ft1000_submit_rx_urb function.
> staging: ft1000: Fix coding style in ft1000_copy_up_pkt function.
> staging: ft1000: Fix coding style in ft1000_open function.
> staging: ft1000: Fix coding style in ft1000_close function.
> staging: ft1000: Fix coding style in ft1000_chkcard function.
> staging: ft1000: Fix coding style in ft1000_receive_cmd function.
> staging: ft1000: Fix coding style in ft1000_dsp_prov function.
> staging: ft1000: Fix coding style in ft1000_proc_drvmsg function.
>
> drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 6 +-
> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 1724 +++++++++++-----------
> drivers/staging/ft1000/ft1000-usb/ft1000_usb.h | 4 +-
After applying this series, I get the following build error:
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c: In function ‘ft1000_proc_drvmsg’:
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c:1825:5: error: implicit declaration of function ‘CardSendCommand’
So I've dropped the whole series.
Care to try it again?
thanks,
greg k-h
prev parent reply other threads:[~2011-03-10 0:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 8:21 [PATCH 00/21] Coding style and minor changes in ft1000_hw Marek Belisko
2011-03-07 8:21 ` [PATCH 01/21] staging: ft1000: Replace camelcase CardSendCommand function name Marek Belisko
2011-03-07 8:21 ` [PATCH 02/21] staging: ft1000: Fix coding style in card_send_command function Marek Belisko
2011-03-07 8:21 ` [PATCH 03/21] staging: ft1000: Fix coding style in dsp_reload function Marek Belisko
2011-03-07 8:21 ` [PATCH 04/21] staging: ft1000: Fix coding style in ft1000_reset_asic function Marek Belisko
2011-03-07 8:21 ` [PATCH 05/21] staging: ft1000: Fix coding style in ft1000_reset_card function Marek Belisko
2011-03-07 8:21 ` [PATCH 06/21] staging: ft1000: Fix identation in ftnet_ops struct Marek Belisko
2011-03-07 8:21 ` [PATCH 07/21] staging: ft1000: Fix coding style in init_ft1000_netdev function Marek Belisko
2011-03-07 8:21 ` [PATCH 08/21] staging: ft1000: Change return value for " Marek Belisko
2011-03-07 8:21 ` [PATCH 09/21] staging: ft1000: Fix coding style in reg_ft1000_netdev function Marek Belisko
2011-03-07 8:21 ` [PATCH 10/21] staging: ft1000: Fix coding style in ft1000_reset function Marek Belisko
2011-03-07 8:21 ` [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function Marek Belisko
2011-03-07 15:55 ` Dan Carpenter
2011-03-07 19:25 ` Belisko Marek
2011-03-07 20:38 ` Dan Carpenter
2011-03-07 22:01 ` Greg KH
2011-03-08 11:34 ` [PATCH 11/21 v2] " Marek Belisko
2011-03-07 8:21 ` [PATCH 12/21] staging: ft1000: Fix coding style in ft1000_copy_down_pkt function Marek Belisko
2011-03-07 8:21 ` [PATCH 13/21] staging: ft1000: Fix coding style in ft1000_start_xmit function Marek Belisko
2011-03-07 8:21 ` [PATCH 14/21] staging: ft1000: Fix coding style in ft1000_submit_rx_urb function Marek Belisko
2011-03-08 11:33 ` [PATCH 14/21 v2] " Marek Belisko
2011-03-07 8:21 ` [PATCH 15/21] staging: ft1000: Fix coding style in ft1000_copy_up_pkt function Marek Belisko
2011-03-07 8:21 ` [PATCH 16/21] staging: ft1000: Fix coding style in ft1000_open function Marek Belisko
2011-03-07 8:21 ` [PATCH 17/21] staging: ft1000: Fix coding style in ft1000_close function Marek Belisko
2011-03-07 8:21 ` [PATCH 18/21] staging: ft1000: Fix coding style in ft1000_chkcard function Marek Belisko
2011-03-07 8:21 ` [PATCH 19/21] staging: ft1000: Fix coding style in ft1000_receive_cmd function Marek Belisko
2011-03-07 8:21 ` [PATCH 20/21] staging: ft1000: Fix coding style in ft1000_dsp_prov function Marek Belisko
2011-03-07 8:21 ` [PATCH 21/21] staging: ft1000: Fix coding style in ft1000_proc_drvmsg function Marek Belisko
2011-03-10 0:00 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310000022.GA17741@kroah.com \
--to=greg@kroah.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.belisko@open-nandra.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.