From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Bob Liu <lliubbo@gmail.com>,
linux-mm@kvack.org, hch@lst.de, hughd@google.com,
npiggin@kernel.dk
Subject: Re: [PATCH] shmem: put inode if alloc_file failed
Date: Thu, 10 Mar 2011 00:03:24 +0000 [thread overview]
Message-ID: <20110310000324.GC22723@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20110309145859.dbe31df5.akpm@linux-foundation.org>
On Wed, Mar 09, 2011 at 02:58:59PM -0800, Andrew Morton wrote:
> > +put_inode:
> > + iput(inode);
> > put_dentry:
> > path_put(&path);
> > put_memory:
>
> Is this correct? We've linked the inode to the dentry with
> d_instantiate(), so the d_put() will do the iput() on the inode.
ITYM path_put() and yes, it will. There's no leak.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-10 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 9:14 [PATCH] shmem: put inode if alloc_file failed Bob Liu
2011-03-08 9:15 ` [PATCH] shmem: using goto to replace several return Bob Liu
2011-03-09 23:01 ` Andrew Morton
2011-03-09 22:58 ` [PATCH] shmem: put inode if alloc_file failed Andrew Morton
2011-03-10 0:03 ` Al Viro [this message]
2011-03-11 10:12 ` Bob Liu
2011-03-11 10:20 ` Bob Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310000324.GC22723@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=lliubbo@gmail.com \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.