From: Stephen Hemminger <shemminger@vyatta.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
xen-devel <xen-devel@lists.xensource.com>,
Ben Hutchings <bhutchings@solarflare.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [GIT/PATCH v4] xen network backend driver
Date: Thu, 10 Mar 2011 09:15:55 -0800 [thread overview]
Message-ID: <20110310091555.0fa8764d@nehalam> (raw)
In-Reply-To: <1299776554.17339.824.camel@zakaz.uk.xensource.com>
On Thu, 10 Mar 2011 17:02:33 +0000
Ian Campbell <Ian.Campbell@citrix.com> wrote:
> +struct xenvif {
> + /* Unique identifier for this interface. */
...
> + struct net_device_stats stats;
> +
There is already a stats struct in net_device in current kernel
versions, unless there is a compelling reason otherwise
please use that.
Also, you probably want to implement per-cpu and 64 bit
stats.
--
next prev parent reply other threads:[~2011-03-10 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 17:02 [SPAM] [GIT/PATCH v4] xen network backend driver Ian Campbell
2011-03-10 17:14 ` Stephen Hemminger
2011-03-10 17:17 ` Ben Hutchings
2011-03-11 10:30 ` Ian Campbell
2011-03-10 17:15 ` Stephen Hemminger [this message]
2011-03-10 17:30 ` Ben Hutchings
2011-03-11 10:22 ` Ian Campbell
2011-03-11 17:24 ` Stephen Hemminger
2011-03-10 17:33 ` Michał Mirosław
2011-03-10 17:43 ` [PoC PATCH] net: convert xen-netfront to hw_features Michał Mirosław, Michał Mirosław
2011-03-10 17:47 ` [PATCH] net: convert xen-netfront to hw_features, " Michał Mirosław
2011-03-14 13:43 ` [GIT/PATCH v4] xen network backend driver Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310091555.0fa8764d@nehalam \
--to=shemminger@vyatta.com \
--cc=Ian.Campbell@citrix.com \
--cc=bhutchings@solarflare.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.