All of lore.kernel.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] macb: detect hclk presence from platform data
Date: Thu, 10 Mar 2011 10:15:54 +0000	[thread overview]
Message-ID: <20110310101554.GD11273@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1299751843-9743-3-git-send-email-jamie@jamieiles.com>

On Thu, Mar 10, 2011 at 10:10:37AM +0000, Jamie Iles wrote:
> Rather than detecting whether we need to do a clk_get() and enable on
> the "hclk" based on the kernel configuration, add an extra field to the
> platform data.  This makes it cleaner to add more supported
> architectures without lots of ifdeffery.

Why not have the platform provide a dummy hclk if no real hclk exists?

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jamie Iles <jamie@jamieiles.com>
Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	nicolas.ferre@atmel.com
Subject: Re: [PATCH 2/8] macb: detect hclk presence from platform data
Date: Thu, 10 Mar 2011 10:15:54 +0000	[thread overview]
Message-ID: <20110310101554.GD11273@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1299751843-9743-3-git-send-email-jamie@jamieiles.com>

On Thu, Mar 10, 2011 at 10:10:37AM +0000, Jamie Iles wrote:
> Rather than detecting whether we need to do a clk_get() and enable on
> the "hclk" based on the kernel configuration, add an extra field to the
> platform data.  This makes it cleaner to add more supported
> architectures without lots of ifdeffery.

Why not have the platform provide a dummy hclk if no real hclk exists?

  reply	other threads:[~2011-03-10 10:15 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 10:10 [PATCH 0/8] macb: add support for Cadence GEM Jamie Iles
2011-03-10 10:10 ` Jamie Iles
2011-03-10 10:10 ` [PATCH 1/8] macb: unify at91 and avr32 platform data Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 13:06   ` Nicolas Ferre
2011-03-10 13:06     ` Nicolas Ferre
2011-03-10 13:17     ` Jamie Iles
2011-03-10 13:17       ` Jamie Iles
2011-03-11  1:41       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11  1:41         ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11  8:56         ` Jamie Iles
2011-03-11  8:56           ` Jamie Iles
2011-03-11 12:52           ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 12:52             ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:25             ` Jamie Iles
2011-03-11 13:25               ` Jamie Iles
2011-03-11 13:37               ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:37                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:53                 ` Jamie Iles
2011-03-11 13:53                   ` Jamie Iles
2011-03-10 10:10 ` [PATCH 2/8] macb: detect hclk presence from " Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 10:15   ` Russell King - ARM Linux [this message]
2011-03-10 10:15     ` Russell King - ARM Linux
2011-03-10 11:41     ` Jamie Iles
2011-03-10 11:41       ` Jamie Iles
2011-03-10 11:45       ` Jamie Iles
2011-03-10 11:45         ` Jamie Iles
2011-03-11  1:44   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11  1:44     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11  8:54     ` Jamie Iles
2011-03-11  8:54       ` Jamie Iles
2011-03-11 12:47       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 12:47         ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:08         ` Jamie Iles
2011-03-11 13:08           ` Jamie Iles
2011-03-11 13:39           ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:39             ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-10 10:10 ` [PATCH 3/8] macb: convert printk to pr_ and friends Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 22:48   ` Joe Perches
2011-03-10 22:48     ` Joe Perches
2011-03-11  0:09     ` Jamie Iles
2011-03-11  0:09       ` Jamie Iles
2011-03-11 12:53   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 12:53     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-10 10:10 ` [PATCH 4/8] macb: initial support for Cadence GEM Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-11 13:14   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:14     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:30     ` Jamie Iles
2011-03-11 13:30       ` Jamie Iles
2011-03-11 13:34       ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:34         ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 14:08         ` Jamie Iles
2011-03-11 14:08           ` Jamie Iles
2011-03-10 10:10 ` [PATCH 5/8] macb: handle HW address registers for GEM devices Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 10:10 ` [PATCH 6/8] macb: support higher rate GEM MDIO clock divisors Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 10:10 ` [PATCH 7/8] macb: support statistics for GEM devices Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-10 10:10 ` [PATCH 8/8] macb: support data bus widths > 32 bits Jamie Iles
2011-03-10 10:10   ` Jamie Iles
2011-03-11 12:55   ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 12:55     ` Jean-Christophe PLAGNIOL-VILLARD
2011-03-11 13:15     ` Jamie Iles
2011-03-11 13:15       ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110310101554.GD11273@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.