From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 02/17] ST SPEAr13xx: Added PCIe host controller base driver support.
Date: Thu, 10 Mar 2011 15:38:26 +0100 [thread overview]
Message-ID: <201103101538.26428.arnd@arndb.de> (raw)
In-Reply-To: <AANLkTik4dtJwzgwb-h1WSHjJMFthyc0-pqSCninafuA7@mail.gmail.com>
On Thursday 10 March 2011, shiraz hashim wrote:
> >> diff --git a/arch/arm/mach-spear13xx/include/mach/hardware.h b/arch/arm/mach-spear13xx/include/mach/hardware.h
> >> index fd8c2dc..c3fb454 100644
> >> --- a/arch/arm/mach-spear13xx/include/mach/hardware.h
> >> +++ b/arch/arm/mach-spear13xx/include/mach/hardware.h
> >> @@ -28,4 +28,11 @@
> >> /* typesafe io address */
> >> #define __io_address(n) __io(IO_ADDRESS(n))
> >
> > I could not find the definition for __io() here, but I suspect this is
> > wrong. If __io_address() is what you use for accessing the direct-mapped
> > MMIO registers, it cannot also be what you use to access the PCIe PIO
> > ports, so most likely one of the two is broken. Can you explain?
>
> This is not used in PCIe and infact is not part of this PCIe patch.
> This is used at few places in the architecture code.
Let me rephrase my point:
The __io() macro is used for accessing PIO registers in PCIe drivers,
it needs to be defined to convert I/O port numbers between PCIBIOS_MIN_IO
and IO_SPACE_LIMIT to the virtual address that is mapped to the I/O
space registers on your PCIe bus.
__io_address() is used in spear13xx to map from physical addresses
in the SOC to virtual addresses that are part of the linear mapping
set up through iotable_init().
These two are not the same, so I believe that either __io_address()
or __io() is broken.
Arnd
next prev parent reply other threads:[~2011-03-10 14:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 11:27 [PATCH V6 00/17] Adding devices support for all spear machines Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 01/17] ST SPEAr13xx: Added ARM PL061 GPIO Support Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 02/17] ST SPEAr13xx: Added PCIe host controller base driver support Viresh Kumar
2011-03-01 15:10 ` Arnd Bergmann
2011-03-10 12:45 ` shiraz hashim
2011-03-10 14:38 ` Arnd Bergmann [this message]
2011-03-10 12:56 ` pratyush
2011-03-01 11:27 ` [PATCH V6 03/17] ST SPEAr: Adding PLGPIO driver for spear platform Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 04/17] ST SPEAr3xx: Adding support for ST's PWM IP Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 05/17] ST SPEAr: Adding Watchdog support on spear3xx & spear6xx machines Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 06/17] ST SPEAr3xx: Adding RAS uart devices Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 07/17] ST SPEAr320: Adding support for CAN Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 08/17] ST SPEAr3xx: EMI (External Memory Interface) controller driver Viresh Kumar
2011-03-01 11:27 ` [PATCH V6 09/17] ST SPEAr: Adding machine support for rtc-spear Viresh Kumar
2011-03-01 11:30 ` [PATCH V6 10/17] ST SPEAr: adding support for synopsis i2c designware Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 11/17] ST SPEAr: Adding machine support for USB host Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 12/17] ST SPEAr: Adding machine support for keyboard Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 13/17] ST SPEAr: Adding machine support for nand Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 14/17] ST SPEAr: Adding support for SSP PL022 Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 15/17] ST SPEAr: Adding support for SDHCI (SDIO) Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 16/17] ST SPEAr Power Management: Added the support for Standby mode Viresh Kumar
2011-03-01 11:31 ` [PATCH V6 17/17] ST SPEAr: Updating defconfigs Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103101538.26428.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.