From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
linux-nfs@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] NFS: Fix handling of commmand line options for NFSROOT
Date: Thu, 10 Mar 2011 16:07:20 +0000 [thread overview]
Message-ID: <20110310160720.GC27206@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <382578FF-22A9-4840-B3A7-EFEFA5453C35@oracle.com>
On Thu, Mar 10, 2011 at 10:59:24AM -0500, Chuck Lever wrote:
> On Mar 10, 2011, at 10:43 AM, Mark Brown wrote:
> > Commmit 972903 (NFS: NFSROOT should default to "proto=udp") added a
> > default NFS mount option using the existing in-kernel code to parse
> > mount options out of the command line. This exposed a bug in the
> Looks like a real bug.
Well, it's stopped me booting any of my systems with -next for a couple
of days :)
> We might be better off teaching root_nfs_cat() to deal with the extra
> comma as necessary right when we concatenate the options strings.
> That would simplify it's callers.
The thought did cross my mind, yes.
next prev parent reply other threads:[~2011-03-10 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 15:43 [PATCH] NFS: Fix handling of commmand line options for NFSROOT Mark Brown
2011-03-10 15:59 ` Chuck Lever
2011-03-10 16:07 ` Mark Brown [this message]
2011-03-10 17:11 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310160720.GC27206@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=Trond.Myklebust@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.