All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue
Date: Thu, 10 Mar 2011 12:35:49 -0500	[thread overview]
Message-ID: <20110310173549.GC19609@infradead.org> (raw)
In-Reply-To: <1299715529-11026-4-git-send-email-david@fromorbit.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

> +STATIC void
> +xfs_flush_worker(
> +	struct work_struct *work)
> +{
> +	struct xfs_mount *mp = container_of(work,
> +					struct xfs_mount, m_flush_work);
> +
> +	xfs_sync_data(mp, SYNC_TRYLOCK);
> +	xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_WAIT);
> +	xfs_log_force(mp, XFS_LOG_SYNC);

No actually new in this patch: but what's the point of the log force
here?  xfs_sync_data just did one before returning.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2011-03-10 17:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10  0:05 [PATCH 0/6] xfs: Reduce OOM kill problems under heavy load V2 Dave Chinner
2011-03-10  0:05 ` [PATCH 1/6] xfs: introduce inode cluster buffer trylocks for xfs_iflush Dave Chinner
2011-03-10 17:31   ` Christoph Hellwig
2011-03-10  0:05 ` [PATCH 2/6] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-03-10 17:34   ` Christoph Hellwig
2011-03-18  3:39     ` Dave Chinner
2011-03-10  0:05 ` [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-03-10 17:35   ` Christoph Hellwig [this message]
2011-03-18  3:39     ` Dave Chinner
2011-03-10  0:05 ` [PATCH 4/6] xfs: introduce background inode reclaim work Dave Chinner
2011-03-10 17:40   ` Christoph Hellwig
2011-03-18  4:00     ` Dave Chinner
2011-03-10  0:05 ` [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-03-10 17:48   ` Christoph Hellwig
2011-03-18  4:06     ` Dave Chinner
2011-03-19 13:45       ` Christoph Hellwig
2011-04-03  0:38         ` Dave Chinner
2011-04-03 10:59           ` Christoph Hellwig
2011-04-04  2:11             ` Dave Chinner
2011-03-10  0:05 ` [PATCH 6/6] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-03-10 21:31   ` Christoph Hellwig
2011-03-18  4:07     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110310173549.GC19609@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.