All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Phil Carmody <ext-phil.2.carmody@nokia.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] sysfs: add more info to the oops dump
Date: Thu, 10 Mar 2011 13:27:47 -0800	[thread overview]
Message-ID: <20110310212746.GA3361@suse.de> (raw)
In-Reply-To: <1299791440-21545-1-git-send-email-ext-phil.2.carmody@nokia.com>

On Thu, Mar 10, 2011 at 11:10:40PM +0200, Phil Carmody wrote:
> If we're going to remember which file we accessed, we might as well
> also remember whether it was a read or a write, and if the latter,
> some indication of what was written.
> 
> Changes in V2: restrict to just one line.

Looks nicer, but you forgot to address the "magic value" trick you used
that I mentioned last time.  Please fix that up.

thanks,

greg k-h

  reply	other threads:[~2011-03-10 21:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 15:53 [PATCH 1/1] sysfs: add more info to the oops dump Phil Carmody
2011-03-10 16:25 ` Greg KH
2011-03-10 18:32   ` Phil Carmody
2011-03-10 19:02     ` Greg KH
2011-03-10 21:10       ` Phil Carmody
2011-03-10 21:27         ` Greg KH [this message]
2011-03-10 22:27           ` [PATCHv3 0/1] " Phil Carmody
2011-03-10 22:27             ` [PATCHv3 1/1] " Phil Carmody
2011-03-10 22:38               ` Andrew Morton
2011-03-10 22:59                 ` Thomas Gleixner
2011-03-10 23:03                   ` Greg KH
2011-03-10 23:15                     ` Andrew Morton
2011-03-10 23:06                   ` Phil Carmody
2011-03-10 23:13                     ` Thomas Gleixner
2011-03-10 23:22                       ` Andrew Morton
2011-03-10 23:27                         ` Thomas Gleixner
2011-03-10 23:46                           ` Thomas Gleixner
2011-03-10 23:22                       ` Phil Carmody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110310212746.GA3361@suse.de \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ext-phil.2.carmody@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.