From: "Michael S. Tsirkin" <mst@redhat.com>
To: Igor Kovalenko <igor.v.kovalenko@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Benjamin Poirier <benjamin.poirier@gmail.com>,
Jason Wang <jasowang@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH v6 1/3] rtl8139: cleanup FCS calculation
Date: Fri, 11 Mar 2011 08:44:01 +0200 [thread overview]
Message-ID: <20110311064216.GA6771@redhat.com> (raw)
In-Reply-To: <AANLkTimbTMucJJ5cntvUX3JyT3oY503O8tFTuKguHwZw@mail.gmail.com>
On Fri, Mar 11, 2011 at 08:35:10AM +0300, Igor Kovalenko wrote:
> On Fri, Mar 11, 2011 at 3:35 AM, Benjamin Poirier
> <benjamin.poirier@gmail.com> wrote:
> > clean out ifdef's around ethernet checksum calculation
> >
> > Signed-off-by: Benjamin Poirier <benjamin.poirier@gmail.com>
> > Cc: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
> > Cc: Jason Wang <jasowang@redhat.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Blue Swirl <blauwirbel@gmail.com>
> > ---
> > hw/rtl8139.c | 20 +++-----------------
> > 1 files changed, 3 insertions(+), 17 deletions(-)
>
> Signed-off-by: Igor V. Kovalenko <igor.v.kovalenko@gmail.com>
I think you mean Acked-by or Tested-by. Signed-off-by is for when you
forward someone's patch to the list.
> --
> Kind regards,
> Igor V. Kovalenko
next prev parent reply other threads:[~2011-03-11 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 0:35 [Qemu-devel] [PATCH v6] rtl8139: add vlan support Benjamin Poirier
2011-03-11 0:35 ` [Qemu-devel] [PATCH v6 1/3] rtl8139: cleanup FCS calculation Benjamin Poirier
2011-03-11 5:35 ` [Qemu-devel] " Igor Kovalenko
2011-03-11 6:44 ` Michael S. Tsirkin [this message]
2011-03-11 6:49 ` Igor Kovalenko
2011-03-11 0:35 ` [Qemu-devel] [PATCH v6 2/3] rtl8139: add vlan tag extraction Benjamin Poirier
2011-03-18 9:32 ` Jason Wang
2011-03-11 0:35 ` [Qemu-devel] [PATCH v6 3/3] rtl8139: add vlan tag insertion Benjamin Poirier
2011-03-18 9:33 ` Jason Wang
2011-03-18 5:50 ` [Qemu-devel] [PATCH v6] rtl8139: add vlan support Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311064216.GA6771@redhat.com \
--to=mst@redhat.com \
--cc=benjamin.poirier@gmail.com \
--cc=blauwirbel@gmail.com \
--cc=igor.v.kovalenko@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.