From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: chris.mason@oracle.com, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: stop using the page cache to back the buffer cache
Date: Fri, 11 Mar 2011 05:16:42 -0500 [thread overview]
Message-ID: <20110311101642.GA15786@infradead.org> (raw)
In-Reply-To: <1299719104-11961-1-git-send-email-david@fromorbit.com>
> + if (((unsigned long)(bp->b_addr + bp->b_buffer_length - 1) &
> + PAGE_MASK) !=
> + ((unsigned long)bp->b_addr & PAGE_MASK)) {
> + /* b_addr spans two pages - use alloc_page instead */
> + kmem_free(bp->b_addr);
> + bp->b_addr = NULL;
> + goto use_alloc_page;
> + }
Did you manage to hit this case? If it happens with any frequency under
real workloads we really need to find a wayto avoid the allocation to
start with.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-11 10:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 1:05 [PATCH] xfs: stop using the page cache to back the buffer cache Dave Chinner
2011-03-11 10:16 ` Christoph Hellwig [this message]
2011-03-11 23:02 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311101642.GA15786@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.