From: Florian Fainelli <florian@openwrt.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org
Subject: [PATCH] VLYNQ: vlynq_enable_device should try remote enabling first
Date: Fri, 11 Mar 2011 11:57:28 +0100 [thread overview]
Message-ID: <201103111157.28347.florian@openwrt.org> (raw)
I noticed device lockups on TNETD7200 chips when vlynq_enable_device tried
enabling the device in the following order: external -> local -> remote
inverting the external and remote order fixes the lock up and allows normal
operation of the remote VLYNQ device on all TNETD generations (7100, 7200,
7300).
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index f885c86..0dd05ce 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -516,9 +516,9 @@ static int __vlynq_enable_device(struct vlynq_device *dev)
!__vlynq_try_external(dev))
return 0;
} else {
- if (!__vlynq_try_external(dev) ||
- !__vlynq_try_local(dev) ||
- !__vlynq_try_remote(dev))
+ if (!__vlynq_try_remote(dev) ||
+ !__vlynq_try_local(dev) ||
+ !__vlynq_try_external(dev))
return 0;
}
break;
--
1.7.1
next reply other threads:[~2011-03-11 10:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 10:57 Florian Fainelli [this message]
2011-06-02 13:46 ` [PATCH] VLYNQ: vlynq_enable_device should try remote enabling first Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103111157.28347.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.