All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Sam Liao <phyomh@gmail.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	acme@redhat.com, Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] Add inverted call graph report support to perf tool
Date: Fri, 11 Mar 2011 13:07:25 +0100	[thread overview]
Message-ID: <20110311120723.GC1826@nowhere> (raw)
In-Reply-To: <20110311115657.GB1826@nowhere>

On Fri, Mar 11, 2011 at 12:57:01PM +0100, Frederic Weisbecker wrote:
> On Thu, Mar 10, 2011 at 10:32:43PM +0800, Sam Liao wrote:
> >  the sysprof that Ingo mentioned.
> 
> sysprof does something like that?
> 
> Note, another reason to avoid abusing the event.ip to group
> per caller, is that we could be able to:
> 
> perf report -s caller,sym -g caller
> 
> If we limit callchains to start from a given foo.so, this may
> sort hists per caller and then per endpoint.
> 
> If your library offers function func1, func2, etc... It will sort
> them per usage (func1 has been first used, then func2, etc...)

I meant func1 has been the most used, then came func2, etc...

> then per endpoint overhead (func1 most often sticks in strcpy(),
> then on read(), etc....).
> 
> Right?
> 
> That may or may not be useful. I don't know. In fact I don't
> want to take the responsibility to judge whether it's useful
> or not. Thus I prefer caller and ip to be two different
> properties of hist entries and not having one absusing the
> other, so that we don't prevent this feature to exist (or many
> other sort combinations I haven't imagined).

  reply	other threads:[~2011-03-11 12:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 13:43 [PATCH] Add inverted call graph report support to perf tool Sam Liao
2011-03-07 18:06 ` Frederic Weisbecker
2011-03-08  8:59   ` Sam Liao
2011-03-10  2:43     ` Frederic Weisbecker
2011-03-10  6:48       ` Ingo Molnar
2011-03-11 10:51         ` Frederic Weisbecker
2011-03-11 14:45           ` Arnaldo Carvalho de Melo
2011-03-10 14:32       ` Sam Liao
2011-03-11 11:57         ` Frederic Weisbecker
2011-03-11 12:07           ` Frederic Weisbecker [this message]
2011-03-12 14:59           ` Sam Liao
2011-05-06  8:54             ` Ingo Molnar
2011-03-12  1:31 ` Arun Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110311120723.GC1826@nowhere \
    --to=fweisbec@gmail.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=phyomh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.