From: "Henrik Rydberg" <rydberg@euromail.se>
To: Michal Marek <mmarek@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: Fix computing srcversion for modules
Date: Sat, 12 Mar 2011 00:06:01 +0100 [thread overview]
Message-ID: <20110311230601.GA1559@polaris.bitmath.org> (raw)
In-Reply-To: <1299879287-30889-1-git-send-email-mmarek@suse.cz>
On Fri, Mar 11, 2011 at 10:34:47PM +0100, Michal Marek wrote:
> Recent change to fixdep:
>
> commit b7bd182176960fdd139486cadb9962b39f8a2b50
> Author: Michal Marek <mmarek@suse.cz>
> Date: Thu Feb 17 15:13:54 2011 +0100
>
> fixdep: Do not record dependency on the source file itself
>
> changed the format of the *.cmd files without realizing that it is also
> used by modpost. Put the path to the source file to the file back, in a
> special variable, so that modpost sees all source files when calculating
> srcversion for modules.
>
> Reported-by: Henrik Rydberg <rydberg@euromail.se>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
Solves the problem, and the patch looks reasonable.
Tested-by: Henrik Rydberg <rydberg@euromail.se>
Thanks!
Henrik
next prev parent reply other threads:[~2011-03-11 23:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 5:40 Linux 2.6.38-rc8 Linus Torvalds
2011-03-08 9:22 ` 2.6.38-rc8: lockdep vs nouveau Alexey Dobriyan
2011-03-08 16:53 ` Alexey Dobriyan
2011-03-11 9:28 ` Linux 2.6.38-rc8 Henrik Rydberg
2011-03-11 14:27 ` Michal Marek
2011-03-11 21:34 ` [PATCH] kbuild: Fix computing srcversion for modules Michal Marek
2011-03-11 23:06 ` Henrik Rydberg [this message]
2011-03-15 5:04 ` Alexander Beregalov
2011-03-15 5:26 ` Alexander Beregalov
2011-03-15 7:24 ` Michal Marek
2011-03-12 10:28 ` Linux 2.6.38-rc8 Török Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110311230601.GA1559@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.