From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Zhang Subject: Re: [ANNOUNCE] cpupowerutils - cpufrequtils extended with quite some features Date: Sat, 12 Mar 2011 12:40:10 +0800 Message-ID: <20110312044010.GB3634@zhy> References: <201103111247.00212.trenn@suse.de> <20110312043409.GA3634@zhy> Reply-To: Yong Zhang Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:date:from:to:cc:subject:message-id:reply-to :references:mime-version:content-type:content-disposition :in-reply-to:user-agent; bh=7hUEM91GtoT865Zo2TwPM94MZreAUEMvCT8GzP4lajQ=; b=FHCHMQpHi34pEKIVrXALCbfR4DC6YoCIUrLhuG/rOc2KJwjHLQAgRwFRdp34k+tYsh JW11New/L0mR//o6c3pbRZKxjwR8zOH5qvCmemfdmYRi3Oz4WrU4vxluBnsZW5caHjRP mhzrt6BrXIcQG8XuOr3Hz2vK+9TmELtCLRvXs= Content-Disposition: inline In-Reply-To: <20110312043409.GA3634@zhy> Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Renninger Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-pm@lists.linux-foundation.org, discuss@lesswatts.org, power@bughost.org, cpufreq@vger.kernel.org, linux@dominikbrodowski.net, Mattia Dongili , Len Brown , Ingo Molnar , herrmann.der.user@googlemail.com, linux-omap@vger.kernel.org, dri-devel@lists.freedesktop.org On Sat, Mar 12, 2011 at 12:34:09PM +0800, Yong Zhang wrote: > On Fri, Mar 11, 2011 at 12:46:59PM +0100, Thomas Renninger wrote: > > Happy testing..., if you have a recent machine, you'll like it! > > > > After some testing phase it would be great to get this tool > > merged into the kernel git repo under: > > tools/power/cpupower > > and replace the Intel HW only supporting tools in tools/power/x86. > > I got below output on my laptop: > > |Mperf || Idle_Stats > CPU | C0 | Cx | Freq || POLL | C1 | C2 | C3 > 0| 36.00| 64.00| 820||1843411670376227.2|1843411670376692.2| 0.00| 0.00 > 1| 44.69| 55.31| 920|| 0.00| 0.00| 0.00| 0.00 > > Seems below patch fix it: forget the declaration of value :) --- --- utils/helpers/sysfs-orig.c 2011-03-12 12:32:06.179827929 +0800 +++ utils/helpers/sysfs.c 2011-03-12 12:35:21.512796546 +0800 @@ -111,7 +111,7 @@ unsigned int idlestate, enum idlestate_value which) { - unsigned long value; + unsigned long long value; unsigned int len; char linebuf[MAX_LINE_LEN]; char *endp; @@ -126,7 +126,7 @@ return 0; } - value = strtoul(linebuf, &endp, 0); + value = strtoull(linebuf, &endp, 0); if ( endp == linebuf || errno == ERANGE ) return 0;