From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/10] ux500: Addressing irq header file dependency for snowball.
Date: Sat, 12 Mar 2011 11:05:14 +0100 [thread overview]
Message-ID: <201103121105.14621.arnd@arndb.de> (raw)
In-Reply-To: <1299884892-6766-10-git-send-email-mathieu.poirier@linaro.org>
On Saturday 12 March 2011 00:08:11 mathieu.poirier at linaro.org wrote:
> --- a/arch/arm/mach-ux500/include/mach/irqs.h
> +++ b/arch/arm/mach-ux500/include/mach/irqs.h
> @@ -36,7 +36,7 @@
> /* This will be overridden by board-specific irq headers */
> #define IRQ_BOARD_END IRQ_BOARD_START
>
> -#ifdef CONFIG_MACH_U8500
> +#if defined CONFIG_MACH_U8500 || CONFIG_MACH_U8500_SNOWBALL
> #include <mach/irqs-board-mop500.h>
> #endif
Can't you just remove the #ifdef entirely? If you want to
be able to build a common kernel, these build-time conditionals
don't work anyway, so the irqs-* files need to be distinct.
The other option would be to remove the #include and directly
include the board specific irqs header from the board file.
In either case, the change would belong in the same patch as
the code that requires it. Just add a short notice about it
in the changelog.
Arnd
next prev parent reply other threads:[~2011-03-12 10:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 23:08 [PATCH 00/10] ux500: support for snowball board mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 01/10] ux500: Introducing foundation " mathieu.poirier at linaro.org
2011-03-12 9:45 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 02/10] ux500: Adding new board files for snowball mathieu.poirier at linaro.org
2011-03-12 9:50 ` Arnd Bergmann
2011-03-12 9:57 ` Russell King - ARM Linux
2011-03-11 23:08 ` [PATCH 03/10] ux500: Adding custom pin configuration file for snowball. - Adding dependency in Makefile. - Adding init function call to board-snowball.c - New header file mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 04/10] ux500: Adding sdi support on snowball mathieu.poirier at linaro.org
2011-03-12 9:53 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 05/10] smsc911x: use shifted register access mathieu.poirier at linaro.org
2011-03-14 8:42 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 06/10] ux500: added snowball-netev with latest fixes mathieu.poirier at linaro.org
2011-03-12 9:58 ` Arnd Bergmann
2011-03-14 9:04 ` Alessandro Rubini
2011-03-11 23:08 ` [PATCH 07/10] ux500: added snowball-digio.c mathieu.poirier at linaro.org
2011-03-12 9:59 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 08/10] ux500: hooking up netdev and digio to compilation mathieu.poirier at linaro.org
2011-03-12 10:00 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 09/10] ux500: Addressing irq header file dependency for snowball mathieu.poirier at linaro.org
2011-03-12 10:05 ` Arnd Bergmann [this message]
2011-03-14 8:49 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 10/10] ux500: adding config file options for snowball board mathieu.poirier at linaro.org
2011-03-12 9:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103121105.14621.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.