From: Greg KH <greg@kroah.com>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
device-driver-devel@blackfin.uclinux.org, stable@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [stable] [PATCH] ad525x_dpot: [BUG] eeprom command send instead of dec/inc all commands
Date: Sat, 12 Mar 2011 09:42:08 -0800 [thread overview]
Message-ID: <20110312174208.GA32737@kroah.com> (raw)
In-Reply-To: <1299935301-3849-1-git-send-email-richard.genoud@gmail.com>
On Sat, Mar 12, 2011 at 02:08:21PM +0100, Richard Genoud wrote:
> When a DEC_ALL or INC_ALL command is issued, an eeprom command is send.
> This is because DPOT_DEC_ALL (DPOT_ADDR_CMD | 0x30) and DPOT_INC_ALL
> (DPOT_ADDR_CMD | 0x58) defines overlap with DPOT_ADDR_EEPROM (0x20).
>
> So, DPOT_ADDR_CMD bit should be tested before DPOT_ADDR_EEPROM bit.
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
> ---
> drivers/misc/ad525x_dpot.c | 4 ++--
This is not how you submit a patch for submission to the stable kernel
tree. Please read Documentation/stable_kernel_rules.txt for how to do
this properly.
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-12 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 13:08 [PATCH] ad525x_dpot: [BUG] eeprom command send instead of dec/inc all commands Richard Genoud
2011-03-12 17:42 ` Greg KH [this message]
2011-03-21 7:57 ` Hennerich, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312174208.GA32737@kroah.com \
--to=greg@kroah.com \
--cc=device-driver-devel@blackfin.uclinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=richard.genoud@gmail.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.