From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Jason Wang <jasowang@redhat.com>,
virtualization@lists.osdl.org, netdev@vger.kernel.org,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len()
Date: Sun, 13 Mar 2011 18:43:59 +0200 [thread overview]
Message-ID: <20110313164359.GA32562@redhat.com> (raw)
In-Reply-To: <1300033927.2761.26.camel@edumazet-laptop>
On Sun, Mar 13, 2011 at 05:32:07PM +0100, Eric Dumazet wrote:
> Le dimanche 13 mars 2011 à 18:19 +0200, Michael S. Tsirkin a écrit :
>
> > Other side is in drivers/net/tun.c and net/packet/af_packet.c
> > At least wrt tun it seems clear socket is not locked.
>
> Yes (assuming you refer to tun_net_xmit())
>
> > Besides queue, dequeue seems to be done without socket locked.
> >
>
> It seems this code (assuming you speak of drivers/vhost/net.c ?) has
> some races indeed.
>
Hmm. Any more besides the one fixed here?
--
MST
next prev parent reply other threads:[~2011-03-13 16:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-17 8:10 [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop Jason Wang
2011-01-17 8:11 ` [PATCH 2/3] vhost-net: Unify the code of mergeable and big buffer handling Jason Wang
2011-01-17 8:36 ` Michael S. Tsirkin
2011-01-18 3:05 ` Jason Wang
2011-01-18 4:37 ` Michael S. Tsirkin
2011-01-18 7:41 ` Jason Wang
2011-01-17 8:11 ` [PATCH 3/3] vhost-net: use lock_sock_fast() in peek_head_len() Jason Wang
2011-01-17 9:33 ` Eric Dumazet
2011-01-17 9:33 ` Eric Dumazet
2011-01-17 9:57 ` Michael S. Tsirkin
2011-03-13 15:06 ` Michael S. Tsirkin
2011-03-13 15:52 ` Eric Dumazet
2011-03-13 16:19 ` Michael S. Tsirkin
2011-03-13 16:32 ` Eric Dumazet
2011-03-13 16:43 ` Michael S. Tsirkin [this message]
2011-03-13 17:41 ` Eric Dumazet
2011-03-13 21:11 ` Michael S. Tsirkin
2011-01-17 8:46 ` [PATCH 1/3] vhost-net: check the support of mergeable buffer outside the receive loop Michael S. Tsirkin
2011-01-18 4:26 ` Jason Wang
2011-01-18 4:36 ` Michael S. Tsirkin
2011-01-18 9:15 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110313164359.GA32562@redhat.com \
--to=mst@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.