From: Yang Ruirui <ruirui.r.yang@tieto.com>
To: <dwmw2@infradead.org>, <linux-mtd@lists.infradead.org>,
<Artem.Bityutskiy@nokia.com>, <ext-jani.1.nikula@nokia.com>,
<ext-phil.2.carmody@nokia.com>, <ruirui.r.yang@tietoenator.com>
Subject: [PATCH 01/02] mtdswap: kill strip error handling option
Date: Mon, 14 Mar 2011 09:50:56 +0800 [thread overview]
Message-ID: <20110314015056.GA6819@darkstar> (raw)
From: Yang Ruirui<ruirui.r.yang@tieto.com>
As Artem Bityutskiy's suggestion, The strict erase error handling option
does not make much sense.
Here kill the option, and still keep the retry times as before.
Signed-off-by: Yang Ruirui<ruirui.r.yang@tieto.com>
---
drivers/mtd/Kconfig | 8 --------
drivers/mtd/mtdswap.c | 8 +-------
2 files changed, 1 insertion(+), 15 deletions(-)
--- mtd-2.6-fc2ff59.orig/drivers/mtd/mtdswap.c 2011-03-12 01:49:31.000000000 +0800
+++ mtd-2.6-fc2ff59/drivers/mtd/mtdswap.c 2011-03-14 09:36:09.283329099 +0800
@@ -156,12 +156,6 @@ struct mtdswap_oobdata {
#define MTDSWAP_ERASE_RETRIES 3 /* Before marking erase block bad */
#define MTDSWAP_IO_RETRIES 3
-#ifdef CONFIG_MTD_SWAP_STRICT
-#define MTDSWAP_STRICT 1
-#else
-#define MTDSWAP_STRICT 0
-#endif
-
enum {
MTDSWAP_SCANNED_CLEAN,
MTDSWAP_SCANNED_DIRTY,
@@ -575,7 +569,7 @@ retry:
ret = mtd->erase(mtd, &erase);
if (ret) {
- if (retries++ < MTDSWAP_ERASE_RETRIES && !MTDSWAP_STRICT) {
+ if (retries++ < MTDSWAP_ERASE_RETRIES) {
dev_warn(d->dev,
"erase of erase block %#llx on %s failed",
erase.addr, mtd->name);
--- mtd-2.6-fc2ff59.orig/drivers/mtd/Kconfig 2011-03-12 01:49:31.000000000 +0800
+++ mtd-2.6-fc2ff59/drivers/mtd/Kconfig 2011-03-14 09:36:45.269995898 +0800
@@ -335,14 +335,6 @@ config MTD_SWAP
The driver provides wear leveling by storing erase counter into the
OOB.
-config MTD_SWAP_STRICT
- bool "Strict erase error handling"
- depends on MTD_SWAP
- help
- Enables strict tolerance on failed erasures, marking erase blocks bad
- right after the first failed operation. With non-strict mode the
- erase operation is retried.
-
source "drivers/mtd/chips/Kconfig"
source "drivers/mtd/maps/Kconfig"
next reply other threads:[~2011-03-14 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 1:50 Yang Ruirui [this message]
2011-03-14 8:39 ` [PATCH 01/02] mtdswap: kill strip error handling option Artem Bityutskiy
2011-03-14 8:58 ` Yang Rui Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314015056.GA6819@darkstar \
--to=ruirui.r.yang@tieto.com \
--cc=Artem.Bityutskiy@nokia.com \
--cc=dwmw2@infradead.org \
--cc=ext-jani.1.nikula@nokia.com \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-mtd@lists.infradead.org \
--cc=ruirui.r.yang@tietoenator.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.