From: Denis Karpov <ext-denis.2.karpov@nokia.com>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/2] omap: rx51: initialize platform data for twl4030 powerbutton
Date: Mon, 14 Mar 2011 13:14:28 +0200 [thread overview]
Message-ID: <20110314111428.GA10465@smart.research.nokia.com> (raw)
In-Reply-To: <alpine.DEB.1.10.1103141253370.23033@esdhcp041196.research.nokia.com>
> >From: Denis Karpov <ext-denis.2.karpov@nokia.com>
> >+static struct twl4030_pwrbutton_data rx51_pwrbutton_data = {
> >+ .rep = 1,
> >+};
> >+
>
> Doesn't this enable them? If you want to keep the default behaviour,
> you can just omit the platform data.
Yes, you are right, thanks. I meant to set it to 0 after testing, but
then it is not needed indeed.
So patch 2/2 is not needed and patch 1/2 does not belong here - I'll
resend it to input/mfd lists/maintainers.
Denis
next prev parent reply other threads:[~2011-03-14 11:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 16:37 [PATCH 0/2] power button repeat input events Denis Karpov
2011-03-11 16:37 ` [PATCH 1/2] input: twl4030-pwrbutton: add support for platform data Denis Karpov
2011-03-11 16:37 ` [PATCH 2/2] omap: rx51: initialize platform data for twl4030 powerbutton Denis Karpov
2011-03-11 19:05 ` Tony Lindgren
2011-03-14 10:57 ` Aaro Koskinen
2011-03-14 11:14 ` Denis Karpov [this message]
2011-03-11 16:55 ` [PATCH 0/2] power button repeat input events Nishanth Menon
2011-03-14 11:13 ` Denis Karpov
2011-03-14 11:40 ` Menon, Nishanth
2011-03-14 14:35 ` Denis Karpov
2011-03-14 14:59 ` Nishanth Menon
2011-03-11 19:04 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314111428.GA10465@smart.research.nokia.com \
--to=ext-denis.2.karpov@nokia.com \
--cc=aaro.koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.