All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Tim Hockin <thockin@google.com>
Cc: "H. Peter Anvin" <hpa@kernel.org>,
	Mike Waychison <mikew@google.com>, Greg KH <greg@kroah.com>,
	Matt Domsch <Matt_Domsch@dell.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Duncan Laurie <dlaurie@google.com>,
	Aaron Durbin <adurbin@google.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	San Mehat <san@google.com>
Subject: Re: [PATCH v2 12/12] driver: Google Memory Console
Date: Mon, 14 Mar 2011 15:23:15 +0100	[thread overview]
Message-ID: <20110314142315.GA1638@elte.hu> (raw)
In-Reply-To: <AANLkTikXE+rMj1GHqZq6YpZOj1_PQJ-K4t8WeVKgsG_B@mail.gmail.com>


* Tim Hockin <thockin@google.com> wrote:

> This same BIOS logic is used across a number of Platforms.  We could
> use something like the vendor strings to trigger this code off, [...]

Correct.

> [...] I suppose, but ick.  It's already in a google/ subdir and wrapped with 
> CONFIG_GOOGLE_MEMCONSOLE.

That's not the point though - in this day and age we simply do not add non-generic 
hacks like that - we've come a long way since the ISA days. The point is to make it 
safe enough to limit its effects not just to CONFIG_GOOGLE_MEMCONSOLE but also to 
affected hardware only.

Thanks,

	Ingo

  reply	other threads:[~2011-03-14 14:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-12  1:42 [PATCH v2 00/12] google firmware support Mike Waychison
2011-03-12  1:43 ` [PATCH v2 01/12] efivars: move efivars globals into struct efivars Mike Waychison
2011-03-12  1:43 ` [PATCH v2 02/12] efivars: Make efivars bin_attributes dynamic Mike Waychison
2011-03-12  1:43 ` [PATCH v2 03/12] efivars: parameterize efivars Mike Waychison
2011-03-12  1:43 ` [PATCH v2 04/12] efivars: Split out variable registration Mike Waychison
2011-03-12  1:43 ` [PATCH v2 05/12] efivars: Parameterize operations Mike Waychison
2011-03-12  1:43 ` [PATCH v2 06/12] efivars: Expose efivars functionality to external drivers Mike Waychison
2011-03-12  1:43 ` [PATCH v2 07/12] efivars: Add Documentation Mike Waychison
2011-03-12  1:43 ` [PATCH v2 08/12] x86: get_bios_ebda_length() Mike Waychison
2011-03-14 15:43   ` Greg KH
2011-03-12  1:43 ` [PATCH v2 09/12] x86: Better comments for get_bios_ebda() Mike Waychison
2011-03-14 15:43   ` Greg KH
2011-03-12  1:43 ` [PATCH v2 10/12] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-03-14 15:45   ` Greg KH
2011-03-14 19:49     ` Mike Waychison
2011-03-14 19:59       ` Greg KH
2011-03-14 20:06         ` Mike Waychison
2011-03-12  1:43 ` [PATCH v2 11/12] driver: Google EFI SMI Mike Waychison
2011-03-14 15:47   ` Greg KH
2011-03-14 20:01     ` Mike Waychison
2011-03-14 20:13       ` Greg KH
2011-03-14 21:09         ` Mike Waychison
2011-03-14 23:05         ` Alan Cox
2011-03-12  1:43 ` [PATCH v2 12/12] driver: Google Memory Console Mike Waychison
2011-03-14  4:54   ` H. Peter Anvin
2011-03-14  4:58     ` Tim Hockin
2011-03-14  5:02       ` H. Peter Anvin
2011-03-14  9:22         ` Ingo Molnar
2011-03-14 14:01           ` Tim Hockin
2011-03-14 14:23             ` Ingo Molnar [this message]
2011-03-14 15:47               ` Greg KH
2011-03-14 20:03     ` Mike Waychison
2011-03-14 22:46       ` H. Peter Anvin
2011-03-12  3:54 ` [PATCH v2 00/12] google firmware support Matt Domsch
2011-03-14 15:42   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110314142315.GA1638@elte.hu \
    --to=mingo@elte.hu \
    --cc=Matt_Domsch@dell.com \
    --cc=adurbin@google.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dlaurie@google.com \
    --cc=greg@kroah.com \
    --cc=hpa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=san@google.com \
    --cc=thockin@google.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.