From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38206 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pz98M-0002II-0F for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:52:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pz98I-0003es-Ue for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:52:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pz98I-0003e8-Ii for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:52:30 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2EEqP8B019589 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 14 Mar 2011 10:52:25 -0400 Date: Mon, 14 Mar 2011 16:51:58 +0200 From: Alon Levy Subject: Re: [Qemu-devel] [PATCH 2/7] introduce libcacard/vscard_common.h Message-ID: <20110314145158.GF31372@playa.tlv.redhat.com> References: <1298460024-23591-1-git-send-email-alevy@redhat.com> <1298460024-23591-3-git-send-email-alevy@redhat.com> <4D7E1FAF.8020605@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D7E1FAF.8020605@redhat.com> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: qemu-devel@nongnu.org On Mon, Mar 14, 2011 at 03:01:19PM +0100, Jes Sorensen wrote: > On 02/23/11 12:20, Alon Levy wrote: > > diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h > > new file mode 100644 > > index 0000000..7449314 > > --- /dev/null > > +++ b/libcacard/vscard_common.h > > @@ -0,0 +1,167 @@ > > +/* Virtual Smart Card protocol definition > > + * > > + * This protocol is between a host using virtual smart card readers, > > + * and a client providing the smart cards, perhaps by emulating them or by > > + * access to real cards. > > + * > > + * Definitions for this protocol: > > + * Host - user of the card > > + * Client - owner of the card > > + * > > + * The current implementation passes the raw APDU's from 7816 and additionally > > + * contains messages to setup and teardown readers, handle insertion and > > + * removal of cards, negotiate the protocol via capabilities and provide > > + * for error responses. > > + * > > + * Copyright (c) 2011 Red Hat. > > + * > > + * This code is licensed under the LGPL. > > Please be more specific on the license. Other code has the following: > * This work is licensed under the terms of the GNU LGPL, version 2.1 or > later. > * See the COPYING.LIB file in the top-level directory. > Yes, I have this ready on the v21 branch.. > [snip] > > +/* VSCMsgInit Client <-> Host > > + * Client sends it on connection, with its own capabilities. > > + * Host replies with VSCMsgInit filling in its capabilities. > > + * > > + * It is not meant to be used for negotiation, i.e. sending more then > > + * once from any side, but could be used for that in the future. > > + * */ > > Looks like some automatic mangling of comments - happens in more than > one place. > > Except for the cosmetic stuff, looks ok. > > Jes > >