From: Stephen Hemminger <shemminger@vyatta.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 3/7] tcp_cubic: make ack train delta value a parameter
Date: Mon, 14 Mar 2011 10:52:14 -0700 [thread overview]
Message-ID: <20110314175439.471612260@vyatta.com> (raw)
In-Reply-To: 20110314175211.788224699@vyatta.com
[-- Attachment #1: tcp-cubic-ackdelta.patch --]
[-- Type: text/plain, Size: 1432 bytes --]
Make the spacing between ACK's that indicates a train a tuneable
value like other hystart values.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/net/ipv4/tcp_cubic.c 2011-03-14 08:19:15.697936023 -0700
+++ b/net/ipv4/tcp_cubic.c 2011-03-14 08:19:18.361944814 -0700
@@ -52,6 +52,7 @@ static int tcp_friendliness __read_mostl
static int hystart __read_mostly = 1;
static int hystart_detect __read_mostly = HYSTART_ACK_TRAIN | HYSTART_DELAY;
static int hystart_low_window __read_mostly = 16;
+static int hystart_ack_delta __read_mostly = 2;
static u32 cube_rtt_scale __read_mostly;
static u32 beta_scale __read_mostly;
@@ -75,6 +76,8 @@ MODULE_PARM_DESC(hystart_detect, "hyrbri
" 1: packet-train 2: delay 3: both packet-train and delay");
module_param(hystart_low_window, int, 0644);
MODULE_PARM_DESC(hystart_low_window, "lower bound cwnd for hybrid slow start");
+module_param(hystart_ack_delta, int, 0644);
+MODULE_PARM_DESC(hystart_ack_delta, "spacing between ack's indicating train (msecs)");
/* BIC TCP Parameters */
struct bictcp {
@@ -343,7 +346,7 @@ static void hystart_update(struct sock *
/* first detection parameter - ack-train detection */
if ((s32)(curr_jiffies - ca->last_jiffies) <=
- msecs_to_jiffies(2)) {
+ msecs_to_jiffies(hystart_ack_delta)) {
ca->last_jiffies = curr_jiffies;
if ((s32) (curr_jiffies - ca->round_start) >
ca->delay_min >> 4)
next prev parent reply other threads:[~2011-03-14 18:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 17:52 [PATCH 0/7] TCP CUBIC Hystart fixes Stephen Hemminger
2011-03-14 17:52 ` [PATCH 1/7] tcp: fix RTT for quick packets in congestion control Stephen Hemminger
2011-03-14 17:52 ` [PATCH 2/7] tcp_cubic: fix comparison of jiffies Stephen Hemminger
2011-03-14 17:52 ` Stephen Hemminger [this message]
2011-03-14 17:52 ` [PATCH 4/7] tcp_cubic: fix clock dependency Stephen Hemminger
2011-03-14 18:51 ` Eric Dumazet
2011-03-14 21:21 ` Stephen Hemminger
2011-03-14 21:37 ` Eric Dumazet
2011-03-14 17:52 ` [PATCH 5/7] tcp_cubic: enable high resolution ack time if needed Stephen Hemminger
2011-03-14 17:52 ` [PATCH 6/7] tcp_cubic: make the delay threshold of HyStart less sensitive Stephen Hemminger
2011-03-14 17:52 ` [PATCH 7/7] tcp_cubic: fix low utilization of CUBIC with HyStart Stephen Hemminger
2011-03-14 22:58 ` [PATCH 0/7] TCP CUBIC Hystart fixes David Miller
2011-03-22 11:34 ` Lucas Nussbaum
2011-03-22 11:35 ` Lucas Nussbaum
2011-03-22 12:05 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314175439.471612260@vyatta.com \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.