From: Ingo Molnar <mingo@elte.hu>
To: Mike Waychison <mikew@google.com>
Cc: Greg KH <greg@kroah.com>, Matt Domsch <Matt_Domsch@dell.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Duncan Laurie <dlaurie@google.com>,
Aaron Durbin <adurbin@google.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Tim Hockin <thockin@google.com>, San Mehat <san@google.com>
Subject: Re: [PATCH v3 5/5] driver: Google Memory Console
Date: Tue, 15 Mar 2011 08:13:34 +0100 [thread overview]
Message-ID: <20110315071334.GA29969@elte.hu> (raw)
In-Reply-To: <20110315065905.12047.71103.stgit@mike.mtv.corp.google.com>
* Mike Waychison <mikew@google.com> wrote:
> +static struct dmi_system_id memconsole_dmi_table[] __initdata = {
> + {
> + .ident = "Google Board",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Google, Inc."),
> + },
> + },
> + {}
> +};
> +MODULE_DEVICE_TABLE(dmi, memconsole_dmi_table);
> +
> +static int __init memconsole_init(void)
> +{
> + int ret;
> +
> + if (!dmi_check_system(memconsole_dmi_table))
> + return -ENODEV;
> +
> + if (!found_memconsole())
> + return -ENODEV;
Ok, that's a much safer method of discovery.
Acked-by: Ingo Molnar <mingo@elte.hu>
Thanks,
Ingo
prev parent reply other threads:[~2011-03-15 7:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 6:58 [PATCH v3 0/5] google firmware support Mike Waychison
2011-03-15 6:58 ` [PATCH v3 1/5] x86: get_bios_ebda_length() Mike Waychison
2011-04-19 23:50 ` Greg KH
2011-04-29 20:42 ` Greg KH
2011-03-15 6:58 ` [PATCH v3 2/5] x86: Better comments for get_bios_ebda() Mike Waychison
2011-03-15 6:58 ` [PATCH v3 3/5] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 21:23 ` Greg KH
2011-04-29 22:55 ` [PATCH v4 1/3] driver: Google EFI SMI Mike Waychison
2011-04-29 23:40 ` Greg KH
2011-04-30 0:14 ` Mike Waychison
2011-04-30 0:39 ` [PATCH v5 " Mike Waychison
2011-04-30 0:39 ` [PATCH v5 2/3] driver: Google Memory Console Mike Waychison
2011-04-30 0:39 ` [PATCH v5 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-29 23:47 ` [PATCH v4 1/3] driver: Google EFI SMI Randy Dunlap
2011-04-29 23:59 ` Mike Waychison
2011-04-29 22:55 ` [PATCH v4 2/3] driver: Google Memory Console Mike Waychison
2011-04-29 22:56 ` [PATCH v4 3/3] Introduce CONFIG_GOOGLE_FIRMWARE Mike Waychison
2011-04-30 10:25 ` Alan Cox
2011-03-15 6:59 ` [PATCH v3 4/5] driver: Google EFI SMI Mike Waychison
2011-03-15 6:59 ` [PATCH v3 5/5] driver: Google Memory Console Mike Waychison
2011-03-15 7:13 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315071334.GA29969@elte.hu \
--to=mingo@elte.hu \
--cc=Matt_Domsch@dell.com \
--cc=adurbin@google.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dlaurie@google.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=san@google.com \
--cc=thockin@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.