From: Wolfram Sang <w.sang@pengutronix.de>
To: Chris Ball <cjb@laptop.org>
Cc: Tony Olech <tony.olech@elandigitalsystems.com>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission
Date: Tue, 15 Mar 2011 10:40:41 +0100 [thread overview]
Message-ID: <20110315094041.GA32015@pengutronix.de> (raw)
In-Reply-To: <m37hc1rsrp.fsf@pullcord.laptop.org>
[-- Attachment #1: Type: text/plain, Size: 805 bytes --]
Hi,
> linux-mmc@ folks, any strong opinions on this driver? My impression is
> that it looks reasonable, but has some areas of being pretty far from
> standard CodingStyle.
I totally agree (sadly it is hard to review because of its size) and I am still
not convinced of the sysfs-entry. Then again, it is a working driver.
> I'm leaning towards merging it as-is and then
> working on incremental fixes; please yell if that sounds like a bad idea.
What about staging? From my all overall impression, the driver would fit there.
Also, there are more people lurking around fixing coding-style than here.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-03-15 9:40 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20B0EAA71DD7413A9A29D0493C6C1D87@AN00536>
[not found] ` <20101116150022.GA27726@void.printf.net>
[not found] ` <27884BED0E3C489C8849EE12A803F536@AN00536>
[not found] ` <m3oc9pnt6g.fsf@pullcord.laptop.org>
[not found] ` <4CE41BE3.1060806@elandigitalsystems.com>
[not found] ` <m3oc9n241c.fsf@pullcord.laptop.org>
2010-11-22 15:05 ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Tony Olech
2010-11-30 6:15 ` Chris Ball
2010-11-30 12:23 ` David Vrabel
2010-12-17 0:43 ` Chris Ball
2010-12-21 15:03 ` Tony Olech
2011-01-06 4:56 ` Chris Ball
2011-01-06 13:18 ` David Vrabel
2011-01-06 13:17 ` David Vrabel
2011-01-20 16:09 ` Tony Olech
2011-01-20 16:11 ` Tony Olech
2011-01-21 10:50 ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission Tony Olech
2011-01-21 21:14 ` Nicolas Pitre
2011-01-22 14:21 ` Wolfram Sang
2011-01-22 19:07 ` Nicolas Pitre
2011-01-23 10:09 ` Wolfram Sang
2011-01-23 14:01 ` Nicolas Pitre
2011-01-24 15:35 ` Wolfram Sang
2011-01-24 16:27 ` Tony Olech
2011-01-24 16:21 ` Tony Olech
2011-01-25 9:13 ` Wolfram Sang
2011-01-25 9:35 ` Tony Olech
2011-01-25 20:40 ` Nicolas Pitre
2011-01-24 16:17 ` Tony Olech
2011-01-24 8:49 ` Tony Olech
2011-01-24 14:43 ` Nicolas Pitre
2011-01-24 15:10 ` Tony Olech
2011-01-24 15:55 ` Nicolas Pitre
2011-01-24 16:08 ` Tony Olech
2011-01-24 16:28 ` Nicolas Pitre
2011-01-24 16:43 ` Tony Olech
2011-03-10 16:13 ` [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Re-Resubmission Tony Olech
2011-03-15 3:01 ` Chris Ball
2011-03-15 9:40 ` Wolfram Sang [this message]
2011-03-15 15:06 ` Chris Ball
2011-03-15 15:41 ` Arnd Bergmann
2011-03-15 16:23 ` Arnd Bergmann
2011-03-15 16:55 ` Tony Olech
2011-04-19 9:05 ` Tony Olech
2011-04-19 12:10 ` Arnd Bergmann
2011-04-19 12:32 ` Tony Olech
2011-04-19 13:21 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315094041.GA32015@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tony.olech@elandigitalsystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.