From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vms173013pub.verizon.net ([206.46.173.13]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1PzaTt-0005sd-EM for openembedded-devel@lists.openembedded.org; Tue, 15 Mar 2011 21:04:37 +0100 Received: from gandalf.denix.org ([unknown] [71.251.48.61]) by vms173013.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0LI400KGG7O69K74@vms173013.mailsrvcs.net> for openembedded-devel@lists.openembedded.org; Tue, 15 Mar 2011 15:02:36 -0500 (CDT) Received: by gandalf.denix.org (Postfix, from userid 1000) id 777D414AF6A; Tue, 15 Mar 2011 16:02:30 -0400 (EDT) Date: Tue, 15 Mar 2011 16:02:30 -0400 From: Denys Dmytriyenko To: openembedded-devel@lists.openembedded.org Message-id: <20110315200230.GB3042@denix.org> References: <1300212835-8779-1-git-send-email-bengardiner@nanometrics.ca> <1300212835-8779-2-git-send-email-bengardiner@nanometrics.ca> MIME-version: 1.0 In-reply-to: <1300212835-8779-2-git-send-email-bengardiner@nanometrics.ca> User-Agent: Mutt/1.5.16 (2007-06-09) Cc: Tom Rini Subject: Re: [PATCH 2/2] bitbake.conf: use .ubifs.img extension in IMAGE_CMD_ubi X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Mar 2011 20:04:37 -0000 Content-type: text/plain; charset=us-ascii Content-disposition: inline On Tue, Mar 15, 2011 at 02:13:55PM -0400, Ben Gardiner wrote: > The current IMAGE_CMD_ubi creates an interim image with a .rootfs.ubifs > extension. > > The ubifs image created is not considered a valid rootfs without a UBI > container. > > Change the filename of the iterim ubifs image used by IMAGE_CMD_ubi to > .ubifs.img to match the IMAGE_CMD_ubifs command. > > Signed-off-by: Ben Gardiner > CC: Tom Rini Same comments, as to patch #1... Acked-by: Denys Dmytriyenko > --- > > Tested successfully in arago; I'm sorry I couldn't find a combination of > MACHINE and DISTRO and image that would build on org.openembedded.dev. > > This patch is a git am fix-up of the patch tested in arago. > > --- > > conf/bitbake.conf | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/conf/bitbake.conf b/conf/bitbake.conf > index 903b9b7..e57a7ad 100644 > --- a/conf/bitbake.conf > +++ b/conf/bitbake.conf > @@ -403,7 +403,7 @@ IMAGE_CMD_cpio.gz = "type cpio >/dev/null; cd ${IMAGE_ROOTFS} && (find . | cpio > IMAGE_CMD_cpio.xz = "type cpio >/dev/null; cd ${IMAGE_ROOTFS} && (find . | cpio -o -H newc | xz -c ${XZ_COMPRESSION_LEVEL} --check=${XZ_INTEGRITY_CHECK} > ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.xz) ${EXTRA_IMAGECMD}" > IMAGE_CMD_cpio.gz.u-boot = "type cpio >/dev/null; cd ${IMAGE_ROOTFS} && (find . | cpio -o -H newc | gzip -c -9 >${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.gz) ${EXTRA_IMAGECMD}; mkimage -A ${UBOOT_ARCH} -O linux -T ramdisk -C gzip -n ${IMAGE_NAME} -d ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.gz ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.gz.u-boot" > IMAGE_CMD_cpio.lzma = "type cpio >/dev/null; cd ${IMAGE_ROOTFS} && (find . | cpio -o -H newc | lzma -c ${LZMA_COMPRESSION_LEVEL} >${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.cpio.lzma) ${EXTRA_IMAGECMD}" > -IMAGE_CMD_ubi = "echo \[ubifs\] > ubinize.cfg ; echo mode=ubi >> ubinize.cfg ; echo image=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs >> ubinize.cfg ; echo vol_id=0 >> ubinize.cfg ; echo vol_type=dynamic >> ubinize.cfg ; echo vol_name=${UBI_VOLNAME} >> ubinize.cfg ; echo vol_flags=autoresize >> ubinize.cfg;mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS} && ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg" > +IMAGE_CMD_ubi = "echo \[ubifs\] > ubinize.cfg ; echo mode=ubi >> ubinize.cfg ; echo image=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img >> ubinize.cfg ; echo vol_id=0 >> ubinize.cfg ; echo vol_type=dynamic >> ubinize.cfg ; echo vol_name=${UBI_VOLNAME} >> ubinize.cfg ; echo vol_flags=autoresize >> ubinize.cfg;mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS} && ubinize -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubi ${UBINIZE_ARGS} ubinize.cfg" > IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.ubifs.img ${MKUBIFS_ARGS}" > > EXTRA_IMAGECMD = "" > -- > 1.7.1 > > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel