From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Re: 2.6.39 merge window (git pulls and what is planned to go in) Date: Tue, 15 Mar 2011 18:16:10 -0400 Message-ID: <20110315221610.GA10785@dumpdata.com> References: <20110310192946.GA9175@dumpdata.com> <1299834691.17339.1797.camel@zakaz.uk.xensource.com> <20110311142109.GA4880@dumpdata.com> <1300201934.17339.2255.camel@zakaz.uk.xensource.com> <1300218769.15812.8.camel@localhost.localdomain> <1300222727.15812.13.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1300222727.15812.13.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "rshriram@cs.ubc.ca" , Jeremy Fitzhardinge , "xen-devel@lists.xensource.com" , Daniel De Graaf , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org > > > 4/5 needs to be upstream (via Rafael) first though, doesn't it? Tha= t's Yes... > > > the keystone here, the rest appears to fall out nicely once that ha= s > > > gone in. > > > > > err, that was not the plan (though what you suggested would also work= ). > > Look at thread > > "Q: Clarification about extra option.." > > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg00267.h= tml > >=20 > > The plan was that I would create a new tree by merging Rafael and > > Stefano's trees. And then rebase my patches on this new tree, send ou= t to > > the list for review. Konrad meanwhile would pull this new tree+patche= s into his So whatever I was hitting earlier on is gone (it also helps when I update= d my tools) I took your tree, stuck it on top of my #linux-next and Stefano's #linux-= next and ran it with 'xm' (4.0) and 'xl' (4.1). The 'xm save -c' and/or 'xm save' worked just great. The ping kept on goi= ng happily doing these 'xm save -c'.=20 The 'xl save -c' on the other hand, failed on me. I don't know what the f= ailure is but I see this state in the guest:=20 test 8 1024 4 ---ss- = 5.3 I should update my xen-uinstable tree just to make sure I am not missing = something obvious. > > tree and push it after Rafael & Stefano's trees have gone in. >=20 > If Rafael is happy with that plan then fine, but I didn't see him ack i= t > in that thread (AFAICT he only acked the concept of what the patch woul= d > do). Either way someone still needs to follow up with him to get an Ack > on the 4/5 patch since it is to the PM core, if he's subsequently also Yup. Please do ping him for his ACK. He needs to OK PM: Add visible HIBERNATION_INTERFACE and hide HIBERNATION patch. Which btw, I looked in a kernel built before your patch and had /sys/power/state contain "mem disk" (good). With your patch and with=20 CONFIG_HIBERNATION=3Dy # CONFIG_HIBERNATION_INTERFACE is not set the /sys/power/state contained only "mem". Which is expected and what the patch is suppose to do. But what surprising is that I still had the /sys/power/disk attribute? Also I saw this during compile: /home/konrad/ssd/linux/kernel/power/hibernate.c:556: warning: =E2=80=98po= wer_down=E2=80=99 defined but not used /home/konrad/ssd/linux/kernel/power/user.c:68: warning: =E2=80=98snapshot= _open=E2=80=99 defined but not used /home/konrad/ssd/linux/kernel/power/user.c:128: warning: =E2=80=98snapsho= t_release=E2=80=99 defined but not used /home/konrad/ssd/linux/kernel/power/user.c:149: warning: =E2=80=98snapsho= t_read=E2=80=99 defined but not used /home/konrad/ssd/linux/kernel/power/user.c:182: warning: =E2=80=98snapsho= t_write=E2=80=99 defined but not used /home/konrad/ssd/linux/kernel/power/user.c:220: warning: =E2=80=98snapsho= t_ioctl=E2=80=99 defined but not used Which you should address (you could send a follow-up patch for it). Hadn't tried to compile this under i386 so no idea if there are any warnings there either. > ok with taking it through a tree other than his own then great. I stuck it in #linux-next-kitchensink Will re-organize it appropiately soon. >=20 > Ian.