* [PATCH] device: add dev_WARN_ONCE
@ 2011-03-16 13:59 Felipe Balbi
2011-03-16 14:39 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2011-03-16 13:59 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Grant Likely, Magnus Damm, Eric W. Biederman, Andi Kleen,
Linux Kernel Mailing List, Felipe Balbi
it's quite useful to print the device name
on the stack dump caused by WARN(), but
there are other cases where we might want
to use WARN_ONCE.
Introduce a helper similar to dev_WARN() for
that case too.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
include/linux/device.h | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/include/linux/device.h b/include/linux/device.h
index 1bf5cf0..83870b8 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -739,13 +739,17 @@ do { \
#endif
/*
- * dev_WARN() acts like dev_printk(), but with the key difference
+ * dev_WARN*() acts like dev_printk(), but with the key difference
* of using a WARN/WARN_ON to get the message out, including the
* file/line information and a backtrace.
*/
#define dev_WARN(dev, format, arg...) \
WARN(1, "Device: %s\n" format, dev_driver_string(dev), ## arg);
+#define dev_WARN_ONCE(dev, condition, format, arg...) \
+ WARN_ONCE(condition, "Device %s\n" format, \
+ dev_driver_string(dev), ## arg)
+
/* Create alias, so I can be autoloaded. */
#define MODULE_ALIAS_CHARDEV(major,minor) \
MODULE_ALIAS("char-major-" __stringify(major) "-" __stringify(minor))
--
1.7.4.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] device: add dev_WARN_ONCE
2011-03-16 13:59 [PATCH] device: add dev_WARN_ONCE Felipe Balbi
@ 2011-03-16 14:39 ` Greg KH
2011-03-16 15:53 ` Felipe Balbi
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2011-03-16 14:39 UTC (permalink / raw)
To: Felipe Balbi
Cc: Grant Likely, Magnus Damm, Eric W. Biederman, Andi Kleen,
Linux Kernel Mailing List
On Wed, Mar 16, 2011 at 03:59:35PM +0200, Felipe Balbi wrote:
> it's quite useful to print the device name
> on the stack dump caused by WARN(), but
> there are other cases where we might want
> to use WARN_ONCE.
>
> Introduce a helper similar to dev_WARN() for
> that case too.
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
Do you have code that needs this for .39, or can it wait for .40?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] device: add dev_WARN_ONCE
2011-03-16 14:39 ` Greg KH
@ 2011-03-16 15:53 ` Felipe Balbi
0 siblings, 0 replies; 3+ messages in thread
From: Felipe Balbi @ 2011-03-16 15:53 UTC (permalink / raw)
To: Greg KH
Cc: Felipe Balbi, Grant Likely, Magnus Damm, Eric W. Biederman,
Andi Kleen, Linux Kernel Mailing List
On Mar 16, 2011, at 4:39 PM, Greg KH wrote:
> On Wed, Mar 16, 2011 at 03:59:35PM +0200, Felipe Balbi wrote:
>> it's quite useful to print the device name
>> on the stack dump caused by WARN(), but
>> there are other cases where we might want
>> to use WARN_ONCE.
>>
>> Introduce a helper similar to dev_WARN() for
>> that case too.
>>
>> Signed-off-by: Felipe Balbi <balbi@ti.com>
>
> Do you have code that needs this for .39, or can it wait for .40?
it can definitely wait :-)
--
balbi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-16 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-16 13:59 [PATCH] device: add dev_WARN_ONCE Felipe Balbi
2011-03-16 14:39 ` Greg KH
2011-03-16 15:53 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.