All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@linux.intel.com>
To: Robert Richter <robert.richter@amd.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"oprofile-list@lists.sf.net" <oprofile-list@lists.sf.net>
Subject: Re: [PATCH] oprofile: Allow setting EDGE/INV/CMASK for Intel counter events
Date: Wed, 16 Mar 2011 08:27:57 -0700	[thread overview]
Message-ID: <20110316152757.GA12845@tassilo.jf.intel.com> (raw)
In-Reply-To: <20110316150450.GO31407@erda.amd.com>

> I would like to write the actual value back so that userland may read
> it:
> 
> 	counter_config->extra &= (ARCH_PERFMON_EVENTSEL_INV|
>                          ARCH_PERFMON_EVENTSEL_EDGE|
>                          ARCH_PERFMON_EVENTSEL_CMASK);
> 	val |= counter_config->extra;
> 
> The value will not be updated emmediately but at least after profiling
> was started.

Okay.

> 
> As an alternative, maybe we better put this extra bits in the
> unit_mask, e.g. in bits [31:16] of the unit mask for bits [31:16] of
> PerfEvtSel? Then, we simply could use the current userland to set it
> up.

We can't anyways, it doesn't support it.

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2011-03-16 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 19:12 [PATCH] oprofile: Allow setting EDGE/INV/CMASK for Intel counter events Andi Kleen
2011-03-16 15:04 ` Robert Richter
2011-03-16 15:27   ` Andi Kleen [this message]
2011-03-16 15:45     ` Robert Richter
2011-03-16 16:56       ` Andi Kleen
2011-03-16 17:00         ` Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316152757.GA12845@tassilo.jf.intel.com \
    --to=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sf.net \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.