From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 8/8] diff --submodule: split into bite-sized pieces
Date: Wed, 16 Mar 2011 14:33:50 -0500 [thread overview]
Message-ID: <20110316193350.GA8179@elie> (raw)
In-Reply-To: <4D8104DC.2010700@web.de>
Jens Lehmann wrote:
> Am 16.03.2011 08:14, schrieb Jonathan Nieder:
>> Introduce two functions:
>>
>> - prepare_submodule_summary prepares the revision walker
>> to list changes in a submodule. That is, it:
>>
>> * finds merge bases between the commits pointed to this
>> path from before ("left") and after ("right") the change;
pointed to at this path before [missing "at", spurious "from"]
>> * checks whether this is a fast-forward or fast-backward;
>> * prepares a revision walk to list commits in the symmetric
>> difference between the commits at each endpoint.
>>
>> It returns nonzero on error.
>>
>> - print_submodule_summary runs the revision walk and saves
>> the result to a strbuf in --left-right format.
runs the revision walk and prints the result in --left-right format
[the strbuf is an implementation detail; not sure how it snuck into
the commit message]
>> The goal is just readability. No functional change intended.
>
> Ack, looks good and makes sense to me.
Thanks, Jens. Looking back over the commit message I see I left in
some typos but the patch still looks good to me fwiw.
prev parent reply other threads:[~2011-03-16 19:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 2:49 [PATCH/RFC] reflog: silence -O3 -Wuninitialized warning Jonathan Nieder
2011-03-16 3:42 ` [PATCH nd/struct-pathspec] declare 1-bit bitfields to be unsigned Jonathan Nieder
2011-03-16 5:38 ` Junio C Hamano
2011-03-16 14:20 ` Nguyen Thai Ngoc Duy
2011-03-16 5:22 ` [PATCH/RFC] reflog: silence -O3 -Wuninitialized warning Junio C Hamano
2011-03-16 6:28 ` Jonathan Nieder
2011-03-16 9:09 ` Johannes Sixt
2011-03-16 9:47 ` Jonathan Nieder
2011-03-16 9:54 ` Johannes Sixt
2011-03-16 10:57 ` Jonathan Nieder
2011-03-16 11:35 ` [RFC/PATCH 0/6] silence -Wuninitialized warnings that previously used the a = a trick Jonathan Nieder
2011-03-16 11:36 ` [PATCH 1/6] match-trees: kill off remaining -Wuninitialized warning Jonathan Nieder
2011-03-16 11:36 ` [PATCH 2/6] run-command: initialize failed_errno to 0 Jonathan Nieder
2011-03-16 11:37 ` [PATCH 3/6] diff --submodule: suppress -Wuninitialized warning by initializing to NULL Jonathan Nieder
2011-03-16 11:37 ` [PATCH 4/6] rsync transport: clarify insert_packed_refs Jonathan Nieder
2011-03-16 11:37 ` [PATCH 5/6] wt-status: protect against invalid change_type Jonathan Nieder
2011-03-16 11:38 ` [PATCH 6/6] fast-import: suppress -Wuninitialized warning by initializing to NULL Jonathan Nieder
2011-03-16 6:53 ` [PATCH 0/8] more warnings and cleanups Jonathan Nieder
2011-03-16 6:59 ` [PATCH 1/8] enums: omit trailing comma for portability Jonathan Nieder
2011-03-16 7:00 ` [PATCH 2/8] compat: make gcc bswap an inline function Jonathan Nieder
2011-03-16 9:21 ` Johannes Sixt
2011-03-16 9:31 ` Jonathan Nieder
2011-03-16 19:44 ` Junio C Hamano
2011-03-16 7:01 ` [PATCH 3/8] svn-fe: do not use "return" for tail call returning void Jonathan Nieder
2011-03-16 7:02 ` [PATCH 4/8] vcs-svn: remove spurious semicolons Jonathan Nieder
2011-03-16 19:47 ` Junio C Hamano
2011-03-16 20:03 ` Jonathan Nieder
2011-03-16 7:08 ` [PATCH 5/8] standardize brace placement in struct definitions Jonathan Nieder
2011-03-18 7:25 ` Junio C Hamano
2011-03-16 7:10 ` [PATCH 6/8] branch: split off function that writes tracking info and commit subject Jonathan Nieder
2011-03-16 7:12 ` [PATCH 7/8] cherry: split off function to print output lines Jonathan Nieder
2011-03-16 7:14 ` [PATCH 8/8] diff --submodule: split into bite-sized pieces Jonathan Nieder
2011-03-16 18:43 ` Jens Lehmann
2011-03-16 19:33 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316193350.GA8179@elie \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.