Re: [PATCH] [CIFS] Allocating SMB2 mids (multiplex identifier structures)

[Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

On Thu, 17 Mar 2011 09:41:34 -0500
Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

> On Thu, Mar 17, 2011 at 9:35 AM, Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> wrote:
> > Btw, what branch are these commits for?  I dearly hope you're not trying
> > to push half-assed code to mainline.  Please do your development on a
> > branch first, and once there is a useable implementation it can be
> > reviewed and synced over.  Take a look at pnfs development for example.
> 
> We have an implementation that was in the test tree for a year, went
> through 3 test events that is being ported.  I don't think it will
> take more than a week or so to get enough of it in.  Unless it gets
> upstream, it is not going to get much wider review than from the
> original group (Pavel, Jeremy etc).  Note that all code is marked as
> "broken" and the majority in distinct c files - this is not that
> different than pNFS, which only recently got usable in mainline but
> was checked in many releases back.
> 

I agree with Christoph here. If the code is marked "broken" then
merging it seems premature. I'd like to see the majority of this code
in a branch that we can test before it goes in anywhere.

The exception would be targeted patches that prepare the existing
code to work with the new SMB2 code. Those can be reviewed and we can
should be able to take those prior to merging the smb2 code wholesale.

-- 
Jeff Layton <jlayton-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>