From: Andres Salomon <dilinger@queued.net>
To: Ed W <lists@wildgooses.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
rpurdie@rpsys.net, linux-geode@lists.infradead.org,
const@mimas.ru, linux-kernel@vger.kernel.org
Subject: Re: Feedback please: [PATCH] leds: New PCEngines Alix LED driver using gpio interface
Date: Thu, 17 Mar 2011 11:22:18 -0700 [thread overview]
Message-ID: <20110317112218.563a5f21@queued.net> (raw)
In-Reply-To: <4D824BEA.70502@wildgooses.com>
On Thu, 17 Mar 2011 17:59:06 +0000
Ed W <lists@wildgooses.com> wrote:
> On 17/03/2011 17:52, Andres Salomon wrote:
> > OLPC stuff lives in arch/x86/platform/olpc; if there was more
> > alix-specific stuff, I'd suggest moving it into something similar.
> > However, I didn't find any. Maybe an arch/x86/platform/geode as a
> > place to collect platform drivers for the various geode-based
> > machines out there (alix, soekris, etc)? Though honestly, I'm not
> > that interested in doing the work to migrate stuff over to there.
>
>
> As this is my first stab at this, I think you are agreeing that the
> current change is ok as a first step at least? (I can have a go at a
> larger code re-org later...)
Yes.
>
> Can I get your final opinion on what should be in the code Copyright
> statement before I resubmit with the module_init change? To recap I
> don't want to alienate anyone, but the code is now based on a)
> leds-5501 and b) a patch from someone not currently credited in the
> file copyright statement? I have stated this origin in the commit
> log and noted the derivation in the code itself. What to do..?
alix_present came from commit
ec9a943ce9f6d6a8ea09587b49d29a020c418c76 , which was from Constantin.
As such, it's probably not a good idea to remove the copyright notice.
next prev parent reply other threads:[~2011-03-17 18:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D81D7FD.1040602@wildgooses.com>
2011-03-17 15:43 ` Feedback please: [PATCH] leds: New PCEngines Alix LED driver using gpio interface Andres Salomon
2011-03-17 16:08 ` Grant Likely
2011-03-17 17:24 ` Ed W
2011-03-17 17:52 ` Andres Salomon
2011-03-17 17:59 ` Ed W
2011-03-17 18:17 ` Grant Likely
2011-03-18 18:12 ` kernel
2011-03-18 18:32 ` Ed W
2011-03-18 22:48 ` Grant Likely
2011-03-19 16:51 ` [PATCH] leds: New PCEngines Alix system driver (enables LEDs via gpio interface) kernel
2011-03-19 17:21 ` Ed W
2011-03-24 3:52 ` Grant Likely
2011-03-19 17:46 ` [PATCH] gpio: Show explicit dependency between GPIO_CS5535 and MFD_CS5535 kernel
2011-03-19 19:59 ` Andres Salomon
2011-03-17 18:22 ` Andres Salomon [this message]
2011-03-17 18:12 ` Feedback please: [PATCH] leds: New PCEngines Alix LED driver using gpio interface Grant Likely
2011-03-17 17:04 ` Ed W
2011-03-17 18:07 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317112218.563a5f21@queued.net \
--to=dilinger@queued.net \
--cc=const@mimas.ru \
--cc=grant.likely@secretlab.ca \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@wildgooses.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.