All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
To: Steve French <smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] consistently use smb_buf_length as be32 for cifs
Date: Thu, 17 Mar 2011 10:29:25 -0400	[thread overview]
Message-ID: <20110317142925.GA3295@infradead.org> (raw)
In-Reply-To: <AANLkTimnfO=GnKC6GK6FZ+H-hfchWhW=HzcUS+HcLH+c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

> -	pSMB->hdr.smb_buf_length += count;
> +	update_rfc1001_len(pSMB, count);

The helper is very confusingly named relatively to the field it updates,
moreover we already have nice helpers to do arithmetics on big endian
fields.  These can just become:

	be32_add_cpu(&pSMB->hdr.smb_buf_length, count);

etc.

  parent reply	other threads:[~2011-03-17 14:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16 22:38 [PATCH] consistently use smb_buf_length as be32 for cifs Steve French
     [not found] ` <AANLkTimnfO=GnKC6GK6FZ+H-hfchWhW=HzcUS+HcLH+c-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-03-17 14:29   ` Christoph Hellwig [this message]
     [not found]     ` <20110317142925.GA3295-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2011-03-17 14:38       ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110317142925.GA3295@infradead.org \
    --to=hch-wegcikhe2lqwvfeawa7xhq@public.gmane.org \
    --cc=linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.