From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] USB: xhci: unsigned char never equals -1
Date: Thu, 17 Mar 2011 20:52:23 +0000 [thread overview]
Message-ID: <20110317205223.GA5399@xanatos> (raw)
In-Reply-To: <20110317193949.GN2008@bicker>
On Thu, Mar 17, 2011 at 10:47:46PM +0300, Dan Carpenter wrote:
> Btw, xhci-ring.c causes some valid looking gcc warnings:
Which git commit are you working off of?
> C [M] drivers/usb/host/xhci-ring.o
> drivers/usb/host/xhci-ring.c: In function ‘handle_port_status’:
> drivers/usb/host/xhci-ring.c:1229: warning: ‘hcd’ may be used uninitialized in this function
> drivers/usb/host/xhci-ring.c: In function ‘handle_tx_event’:
> drivers/usb/host/xhci-ring.c:1895: warning: ‘event_trb’ may be used uninitialized in this function
I think the second warning is just the compiler getting confused, but
I'll look into the first warning. What gcc version are you using? I
had compile-tested the patches I recently sent to Greg, but on an older
(un-updateable, thanks Ubuntu) box with an older gcc.
Sarah Sharp
next prev parent reply other threads:[~2011-03-17 20:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 19:39 [patch] USB: xhci: unsigned char never equals -1 Dan Carpenter
2011-03-17 19:47 ` Dan Carpenter
2011-03-17 20:52 ` Sarah Sharp [this message]
2011-03-17 21:07 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317205223.GA5399@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.