From: Dave Jones <davej@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: make checkpatch warn about memset with swapped arguments.
Date: Thu, 17 Mar 2011 17:51:04 -0400 [thread overview]
Message-ID: <20110317215104.GA12157@redhat.com> (raw)
In-Reply-To: <1300397896.16880.584.camel@gandalf.stny.rr.com>
On Thu, Mar 17, 2011 at 05:38:16PM -0400, Steven Rostedt wrote:
> > Maybe it's just me, but I think it would be better to use bzero() for
> > this operation - it's more readable and it can't be screwed up. Then
> > checkpatch checks for memset(xxx, 0, xxx) and for memset(xxx, xxx, 0)
> > and says "hey, use bzero".
>
> Honestly, I've never had the issues with memset. Maybe back in college.
> But heh, whatever.
You're smarter than the average bear.
Given how often this bug turns up in both userspace and kernelspace,
it's a landmine waiting for someone to step on.
Dave
next prev parent reply other threads:[~2011-03-17 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 4:52 make checkpatch warn about memset with swapped arguments Dave Jones
2011-03-17 19:36 ` Steven Rostedt
2011-03-17 20:02 ` Dave Jones
2011-03-17 20:37 ` Steven Rostedt
2011-03-17 21:11 ` Andrew Morton
2011-03-17 21:32 ` Dave Jones
2011-03-17 21:57 ` Andrew Morton
2011-03-17 22:04 ` Steven Rostedt
2011-03-17 21:38 ` Steven Rostedt
2011-03-17 21:51 ` Dave Jones [this message]
2011-03-17 22:56 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317215104.GA12157@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.