From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-mm@kvack.org, npiggin@kernel.dk, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: flush vmap aliases when mapping fails
Date: Fri, 18 Mar 2011 15:24:14 +0100 [thread overview]
Message-ID: <20110318142414.GV2140@cmpxchg.org> (raw)
In-Reply-To: <20110310073751.GB25374@infradead.org>
On Thu, Mar 10, 2011 at 02:37:51AM -0500, Christoph Hellwig wrote:
> On Thu, Mar 10, 2011 at 10:37:56AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > On 32 bit systems, vmalloc space is limited and XFS can chew through
> > it quickly as the vmalloc space is lazily freed. This can result in
> > failure to map buffers, even when there is apparently large amounts
> > of vmalloc space available. Hence, if we fail to map a buffer, purge
> > the aliases that have not yet been freed to hopefuly free up enough
> > vmalloc space to allow a retry to succeed.
>
> IMHO this should be done by vm_map_ram internally. If we can't get the
> core code fixes we can put this in as a last resort.
Agreed, this should be fixed in the vmalloc-ator.
It is already supposed to purge the lazy-freed mappings before it
fails an allocation, I am trying to figure out what's going on.
Your proposed workaround looks fine to me until vmalloc is fixed.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Dave Chinner <david@fromorbit.com>,
xfs@oss.sgi.com, npiggin@kernel.dk, linux-mm@kvack.org
Subject: Re: [PATCH] xfs: flush vmap aliases when mapping fails
Date: Fri, 18 Mar 2011 15:24:14 +0100 [thread overview]
Message-ID: <20110318142414.GV2140@cmpxchg.org> (raw)
In-Reply-To: <20110310073751.GB25374@infradead.org>
On Thu, Mar 10, 2011 at 02:37:51AM -0500, Christoph Hellwig wrote:
> On Thu, Mar 10, 2011 at 10:37:56AM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > On 32 bit systems, vmalloc space is limited and XFS can chew through
> > it quickly as the vmalloc space is lazily freed. This can result in
> > failure to map buffers, even when there is apparently large amounts
> > of vmalloc space available. Hence, if we fail to map a buffer, purge
> > the aliases that have not yet been freed to hopefuly free up enough
> > vmalloc space to allow a retry to succeed.
>
> IMHO this should be done by vm_map_ram internally. If we can't get the
> core code fixes we can put this in as a last resort.
Agreed, this should be fixed in the vmalloc-ator.
It is already supposed to purge the lazy-freed mappings before it
fails an allocation, I am trying to figure out what's going on.
Your proposed workaround looks fine to me until vmalloc is fixed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-18 14:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 23:37 [PATCH] xfs: flush vmap aliases when mapping fails Dave Chinner
2011-03-10 7:37 ` Christoph Hellwig
2011-03-10 7:37 ` Christoph Hellwig
2011-03-10 22:49 ` Dave Chinner
2011-03-10 22:49 ` Dave Chinner
2011-03-17 14:24 ` Christoph Hellwig
2011-03-17 14:24 ` Christoph Hellwig
2011-03-21 12:25 ` Johannes Weiner
2011-03-21 12:25 ` Johannes Weiner
2011-03-22 12:57 ` Johannes Weiner
2011-03-22 12:57 ` Johannes Weiner
2011-03-27 23:54 ` Dave Chinner
2011-03-27 23:54 ` Dave Chinner
2011-03-18 14:24 ` Johannes Weiner [this message]
2011-03-18 14:24 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110318142414.GV2140@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=linux-mm@kvack.org \
--cc=npiggin@kernel.dk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.