From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 7/8] drm/i915: move sandybridge RC6 enable in resume after ring initialization Date: Mon, 21 Mar 2011 10:46:53 -0700 Message-ID: <20110321104653.4e7afb69@jbarnes-desktop> References: <1300699639-23996-1-git-send-email-zhenyuw@linux.intel.com> <1300699639-23996-8-git-send-email-zhenyuw@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id F07499E82F for ; Mon, 21 Mar 2011 10:46:56 -0700 (PDT) In-Reply-To: <1300699639-23996-8-git-send-email-zhenyuw@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Mon, 21 Mar 2011 17:27:18 +0800 Zhenyu Wang wrote: > Move RC6 enable after we reset rings for all regines, as RC6 on > Sandybridge would setup ring idle state, so I assume we should have > setup rings already. So you're seeing the idle value get clobbered? Otherwise it's it better to set the ring idle value before actually starting the ring? -- Jesse Barnes, Intel Open Source Technology Center