Re: [Qemu-devel] [PATCH] target-arm/helper.c: For float-int conversion helpers pass ints as ints

[Nathan Froyd <froydnj@codesourcery.com>]

On Mon, Mar 21, 2011 at 02:04:31PM +0000, Peter Maydell wrote:
> On 21 March 2011 13:48, Nathan Froyd <froydnj@codesourcery.com> wrote:
> > I like the direction this patch goes; you aren't by any chance going to
> > convert the passing/returning of float* to their appropriate int* types
> > too, are you?
> 
> Nope -- I think that where we're passing or returning an actual
> IEEE single/double to a helper function "float*" is a better type
> than uint32_t: it gives information about what the helper's argument
> semantically is, and it means we don't have every helper that takes
> or returns a float have to include ugly calls to the boxing/unboxing
> macros.

I'm just concerned about what would happen if we turned on softfloat's
"float types are structure types" bit; I'm pretty sure everything would
break horribly on targets that don't pass small structures in
registers.  Admittedly, several targets would be broken by doing so, so
it's not particularly urgent.

-Nathan