All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Takashi Iwai <tiwai@suse.de>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jaroslav Kysela <perex@perex.cz>,
	Liam Girdwood <lrg@slimlogic.co.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org,
	Randy Dunlap <randy.dunlap@oracle.com>,
	Zeng Zhaoming <b32542@freescale.com>
Subject: Re: [build failure] Re: [GIT PULL] sound updates for 2.6.39-rc1
Date: Mon, 21 Mar 2011 17:49:37 +0100	[thread overview]
Message-ID: <20110321164937.GA6381@elte.hu> (raw)
In-Reply-To: <20110321163849.GF2570@opensource.wolfsonmicro.com>


* Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:

> On Mon, Mar 21, 2011 at 05:11:02PM +0100, Ingo Molnar wrote:
> > * Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> 
> > > As indicated that's not a good fix since the affected code is all runtime 
> > > conditional already. [...]
> 
> > Well, AFAICS Randy's patch correctly expresses current infrastructure 
> > dependencies the driver has.
> 
> That's because the driver code is trivially broken, though - the build
> test has identified a flaw in the driver which we should fix.

Trivially broken how? Your mail in the original thread, if i read it right, 
only claimed that it depends on CONFIG_REGULATOR being present while ideally it 
should be invariant to the value of CONFIG_REGULATOR:

 | Since the regulator on the device is optional this isn't the best fix, the 
 | code should be updated to support building without regulator.

If there is some *other* bug there as well then of course it should be fixed 
instead of worked around.

Thanks,

	Ingo

  reply	other threads:[~2011-03-21 16:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-18 14:05 [GIT PULL] sound updates for 2.6.39-rc1 Takashi Iwai
2011-03-21 15:37 ` [build failure] " Ingo Molnar
2011-03-21 15:42   ` Randy Dunlap
2011-03-21 15:56   ` Takashi Iwai
2011-03-21 15:58   ` Mark Brown
2011-03-21 16:11     ` Ingo Molnar
2011-03-21 16:38       ` Mark Brown
2011-03-21 16:49         ` Ingo Molnar [this message]
2011-03-21 16:58           ` Mark Brown
2011-03-22 12:24             ` Mark Brown
2011-03-22 15:38               ` Randy Dunlap
2011-03-22 15:50                 ` Mark Brown
2011-03-22 15:51                 ` Takashi Iwai
2011-03-22 15:57                   ` Randy Dunlap
2011-03-22 16:00                   ` Ingo Molnar
2011-03-22 16:41                     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110321164937.GA6381@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=b32542@freescale.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=perex@perex.cz \
    --cc=randy.dunlap@oracle.com \
    --cc=tiwai@suse.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.