From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45907 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q1vcM-0000CB-Nb
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 03:03:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q1vcJ-00032z-Ms
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 03:03:02 -0400
Received: from hall.aurel32.net ([88.191.126.93]:60985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q1vcJ-00031y-II
	for qemu-devel@nongnu.org; Tue, 22 Mar 2011 03:02:59 -0400
Date: Tue, 22 Mar 2011 07:45:16 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] vmmouse: Fix initialization
Message-ID: <20110322064516.GF19515@ohm.aurel32.net>
References: <4D871FD8.2010400@siemens.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <4D871FD8.2010400@siemens.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On Mon, Mar 21, 2011 at 10:52:24AM +0100, Jan Kiszka wrote:
> Latest refactorings left vmmouse nonfunctional behind. Fix it by adding
> the required device initialization.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/pc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, applied.

> diff --git a/hw/pc.c b/hw/pc.c
> index 4d67d9f..6939c04 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1142,6 +1142,7 @@ void pc_basic_device_init(qemu_irq *isa_irq,
>      vmmouse = isa_try_create("vmmouse");
>      if (vmmouse) {
>          qdev_prop_set_ptr(&vmmouse->qdev, "ps2_mouse", i8042);
> +        qdev_init_nofail(&vmmouse->qdev);
>      }
>      port92 = isa_create_simple("port92");
>      port92_init(port92, &a20_line[1]);
> -- 
> 1.7.1
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net