From: Brad Hards <bradh@frogmouth.net>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct
Date: Tue, 22 Mar 2011 07:44:19 +1100 [thread overview]
Message-ID: <201103220744.20014.bradh@frogmouth.net> (raw)
In-Reply-To: <1300729640-6410-1-git-send-email-peter.maydell@linaro.org>
On Tue, 22 Mar 2011 04:47:18 am Peter Maydell wrote:
> This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine
> structure so that a board model can specify the maximum RAM it will accept.
> We can then produce a friendly diagnostic message when the user tries to
> start qemu with a '-m' option asking for more RAM than that. (Currently
> most of the ARM devboard models respond with an obscure guest crash when
> the guest tries to access RAM and finds device registers instead.)
As a user, I've been bitten by this. Without understanding how qemu works, the
problem is quite surprising: "all I've done is increased the RAM, and now it
just crashes".
I don't think my review of the code will count for much, and I'd prefer to see
the code added rather than not, but you could move the cmd.c macros (MEGABYTES
and TO_MEGABYTES) to some common header and just use those. They are pretty
ugly though...
Brad
next prev parent reply other threads:[~2011-03-21 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 17:47 [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct Peter Maydell
2011-03-21 17:47 ` [Qemu-devel] [PATCH 1/2] Allow boards to specify maximum RAM size Peter Maydell
2011-03-21 17:47 ` [Qemu-devel] [PATCH 2/2] hw: Add maximum RAM specifications for ARM devboard models Peter Maydell
2011-03-21 19:34 ` [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct Anthony Liguori
2011-03-21 20:44 ` Brad Hards [this message]
2011-03-26 11:41 ` Blue Swirl
2011-03-28 10:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103220744.20014.bradh@frogmouth.net \
--to=bradh@frogmouth.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.