All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jakob Pfender <jpfender@elegosoft.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org, lee.marlow@gmail.com,
	markus.heidelberg@web.de, spearce@spearce.org,
	bebarino@gmail.com, ted@tedpavlic.com, tlikonen@iki.fi,
	trast@student.ethz.ch
Subject: Re: [PATCH] git-completion: Add git help completion for aliases
Date: Tue, 22 Mar 2011 09:50:27 +0100	[thread overview]
Message-ID: <20110322085027.GF14520@neumann> (raw)
In-Reply-To: <7v4o6vmvzs.fsf@alter.siamese.dyndns.org>

On Tue, Mar 22, 2011 at 12:53:43AM -0700, Junio C Hamano wrote:
> This is a constructive tangent but if we are going to run $(__git_aliases)
> every time we run _git_help, perhaps it would want a hack similar to the
> way the value for $__git_all_commands is generated just once?

I think this is not necessary.  We already run __git_aliases() every
time after 'git <TAB>', and it was not an issue so far.  And indeed, I
just created 50 aliases, and the time required for __git_aliases()
seems to be negligible:

  $ time __git_aliases
  <bunch of aliases>

  real    0m0.028s
  user    0m0.016s
  sys     0m0.004s

Besides, invoking __git_aliases() every time has the benefit that
newly added aliases will appear immediately in completion suggestions.


Best,
Gábor

  parent reply	other threads:[~2011-03-22  8:50 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-21  9:25 [PATCH] git-completion: Add git help completion for aliases Jakob Pfender
2011-03-21 21:48 ` Junio C Hamano
2011-03-21 22:07   ` Johannes Schindelin
2011-03-22  7:53     ` Junio C Hamano
2011-03-22  8:44       ` Johannes Schindelin
2011-03-22  8:50       ` SZEDER Gábor [this message]
2011-03-22  9:16         ` Erik Faye-Lund
2011-03-22  9:18           ` Erik Faye-Lund
2011-03-22 10:09           ` SZEDER Gábor
2011-03-22 10:28             ` Erik Faye-Lund
2011-03-22 16:38               ` Michael J Gruber
2011-03-22 20:25               ` SZEDER Gábor
2011-03-23 10:32                 ` Erik Faye-Lund
2011-03-23 12:11                   ` Jakub Narebski
2011-03-23 12:16                     ` Erik Faye-Lund
2011-03-22 17:25         ` Junio C Hamano
2011-03-22 21:21           ` SZEDER Gábor
2011-03-22  8:23   ` SZEDER Gábor
2011-03-22  9:23   ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110322085027.GF14520@neumann \
    --to=szeder@ira.uka.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jpfender@elegosoft.com \
    --cc=lee.marlow@gmail.com \
    --cc=markus.heidelberg@web.de \
    --cc=spearce@spearce.org \
    --cc=ted@tedpavlic.com \
    --cc=tlikonen@iki.fi \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.