From: Greg KH <gregkh@suse.de>
To: Oren Weil <oren.jer.weil@intel.com>
Cc: linux-kernel@vger.kernel.org, alan@linux.intel.com, david@woodhou.se
Subject: Re: [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct)
Date: Tue, 22 Mar 2011 09:26:03 -0700 [thread overview]
Message-ID: <20110322162603.GB14737@suse.de> (raw)
In-Reply-To: <1300791092-14319-7-git-send-email-oren.jer.weil@intel.com>
On Tue, Mar 22, 2011 at 12:51:31PM +0200, Oren Weil wrote:
> +/*
> + * Intel MEI client information struct
> + */
> +struct mei_client {
> + u32 max_msg_length;
> + u8 protocol_version;
> + u8 reserved[3];
> +} __packed;
As this is passing the kernel/user boundry, you need to use the proper
data types for it.
So use __u32 and __u8 here please.
> +/*
> + * IOCTL Connect Client Data structure
> + */
> +struct mei_connect_client_data {
> + union {
> + uuid_le in_client_uuid;
> + struct mei_client out_client_propeties;
> + } d;
Why not an anonymous union?
thanks,
greg k-h
next prev parent reply other threads:[~2011-03-22 16:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 10:51 [PATCH 0/7] char/mei: Intel MEI Driver Oren Weil
2011-03-22 10:51 ` [PATCH 1/7] char/mei: PCI device and char driver support Oren Weil
2011-03-22 17:22 ` Arnd Bergmann
2011-03-22 21:57 ` Alan Cox
2011-03-22 22:22 ` Greg KH
2011-03-22 23:04 ` Alan Cox
2011-03-23 7:59 ` Arnd Bergmann
2011-03-22 10:51 ` [PATCH 2/7] char/mei: Interrupt handling Oren Weil
2011-03-22 10:51 ` [PATCH 3/7] char/mei: MEI "Link" layer code - MEI Hardware communications Oren Weil
2011-03-22 10:51 ` [PATCH 4/7] char/mei: MEI driver init flow Oren Weil
2011-03-22 10:51 ` [PATCH 5/7] char/mei: Hardware and MEI driver internal struct definition Oren Weil
2011-03-22 10:51 ` [PATCH 6/7] char/mei: Header file contain the Userland API, (IOCTL and its struct) Oren Weil
2011-03-22 16:26 ` Greg KH [this message]
2011-03-22 16:41 ` Arnd Bergmann
2011-03-22 10:51 ` [PATCH 7/7] char/mei: Updates to char/Kconfig ane char/Makefile Oren Weil
2011-03-23 21:43 ` Valdis.Kletnieks
2011-03-22 16:23 ` [PATCH 0/7] char/mei: Intel MEI Driver Greg KH
2011-03-23 12:25 ` Weil, Oren jer
2011-03-23 13:50 ` Greg KH
2011-03-22 16:50 ` Arnd Bergmann
2011-03-23 7:20 ` Weil, Oren jer
2011-03-23 13:51 ` Greg KH
2011-03-23 15:55 ` Weil, Oren jer
2011-03-23 16:06 ` Greg KH
2011-03-23 16:20 ` Arnd Bergmann
2011-03-24 12:54 ` Weil, Oren jer
2011-03-24 13:10 ` Arnd Bergmann
2011-04-04 15:54 ` Pavel Machek
2011-04-05 6:01 ` Weil, Oren jer
2011-04-18 13:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322162603.GB14737@suse.de \
--to=gregkh@suse.de \
--cc=alan@linux.intel.com \
--cc=david@woodhou.se \
--cc=linux-kernel@vger.kernel.org \
--cc=oren.jer.weil@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.