From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org, Amit Shah <amit.shah@redhat.com>
Subject: [Qemu-devel] [PATCH] virtio-serial: don't crash on invalid input
Date: Tue, 22 Mar 2011 18:32:50 +0200 [thread overview]
Message-ID: <20110322163250.GA6426@redhat.com> (raw)
Fix crash on invalid input in virtio-serial.
Discovered by code review, untested.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/virtio-serial-bus.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index e0bf6c5..8807a2f 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -654,6 +654,9 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id)
id = qemu_get_be32(f);
port = find_port_by_id(s, id);
+ if (!port) {
+ return -EINVAL;
+ }
port->guest_connected = qemu_get_byte(f);
host_connected = qemu_get_byte(f);
--
1.7.3.2.91.g446ac
next reply other threads:[~2011-03-22 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 16:32 Michael S. Tsirkin [this message]
2011-03-22 16:55 ` [Qemu-devel] Re: [PATCH] virtio-serial: don't crash on invalid input Amit Shah
2011-03-23 9:56 ` Michael S. Tsirkin
2011-03-23 16:09 ` Amit Shah
2011-03-23 16:18 ` Michael S. Tsirkin
2011-03-23 16:07 ` Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110322163250.GA6426@redhat.com \
--to=mst@redhat.com \
--cc=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.