All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: [PATCH 0/2] Re: [PATCH 2/2] Actually use retval
Date: Tue, 22 Mar 2011 20:26:54 -0500	[thread overview]
Message-ID: <20110323012654.GA10621@elie> (raw)
In-Reply-To: <7v7hbrkovz.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> The likely fix would be to remove assignment to retval instead.

Like this, maybe?

Jonathan Nieder (2):
  tree-diff: make diff_tree() return void
  tree-diff: make diff_tree_sha1() return void

 diff.h      |    4 ++--
 revision.c  |    9 +++------
 tree-diff.c |   17 ++++++-----------
 3 files changed, 11 insertions(+), 19 deletions(-)

  parent reply	other threads:[~2011-03-23  1:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 12:49 [PATCH 0/2] Fix issues found by gcc 4.6.0 Johannes Schindelin
2011-03-22 12:50 ` [PATCH 1/2] Remove unused variables Johannes Schindelin
2011-03-22 18:15   ` Junio C Hamano
2011-03-22 18:42     ` Johannes Schindelin
2011-03-22 19:43   ` Jonathan Nieder
2011-03-22 12:50 ` [PATCH 2/2] Actually use retval Johannes Schindelin
2011-03-22 18:10   ` Junio C Hamano
2011-03-22 18:20     ` Johannes Schindelin
2011-03-23  1:26     ` Jonathan Nieder [this message]
2011-03-23  1:28       ` [PATCH 1/2] tree-diff: make diff_tree return void Jonathan Nieder
2011-03-23  1:30       ` [PATCH 2/2] tree-diff: make diff_tree_sha1 " Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110323012654.GA10621@elie \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.