From: Steven Rostedt <rostedt@goodmis.org>
To: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [RFC] checkpatch: add option to change warning return value.
Date: Tue, 22 Mar 2011 21:41:17 -0400 [thread overview]
Message-ID: <20110323014117.GA15728@home.goodmis.org> (raw)
In-Reply-To: <20110322232246.GA7450@xanatos>
On Tue, Mar 22, 2011 at 04:22:46PM -0700, Sarah Sharp wrote:
>
> BTW, I'm not a perl hacker, and I don't really understand the reporting code,
> so someone who knows it (Andy?) should make the correct patch. I didn't notice
> before sending, but right now the warning count reporting is bogus, although
> the warnings don't make the script return an error code:
>
>
>
> Note that second-to-last patch should have said 3 warnings. So my patch needs
> to be changed, but I really do want this functionality.
>
> > @@ -1096,6 +1099,9 @@ sub report {
> >
> > push(our @report, $line);
> >
> > + if ($lazy == 1) {
> > + return 0;
> > + }
> > return 1;
> > }
> > sub report_dump {
Instead of this hunk, have:
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 58848e3..54ec3d9 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -316,7 +316,7 @@ for my $filename (@ARGV) {
}
close($FILE);
if (!process($filename)) {
- $exit = 1;
+ $exit = 1 if (!$lazy);
}
@rawlines = ();
@lines = ();
-- Steve
next prev parent reply other threads:[~2011-03-23 1:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 23:13 [RFC] checkpatch: add option to change warning return value Sarah Sharp
2011-03-22 23:22 ` Sarah Sharp
2011-03-22 23:40 ` [RFC v2] Checkpatch: " Sarah Sharp
2011-03-23 1:41 ` Steven Rostedt [this message]
2011-03-24 15:40 ` [RFC] checkpatch: " Sarah Sharp
2011-03-24 18:23 ` Steven Rostedt
2011-03-24 22:02 ` Sarah Sharp
2011-03-23 10:07 ` Johannes Weiner
2011-03-23 18:43 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323014117.GA15728@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.