From: Harry Wei <jiaweiwei.xiyou@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com, akpm@linux-foundation.org
Subject: Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
Date: Wed, 23 Mar 2011 15:00:20 +0800 [thread overview]
Message-ID: <20110323070017.GA3731@gmail.com> (raw)
In-Reply-To: <4D894CD0.9030509@cn.fujitsu.com>
On Wed, Mar 23, 2011 at 09:28:48AM +0800, Li Zefan wrote:
> Harry Wei wrote:
> > Hi us,
> > Clean up CodingStyle for scripts/kconfig/gconf.c.
> >
>
> What makes you think this is a bad style? Does Documentation/CodingStyle say
> so? Does checkpatch.pl make a complain? Do you really think this improves
> readability? I don't think so, and actually it makes the code worse.
But we all write '#include <***>'. I have never seen '# include <***>'.
>
> Run checkpatch.pl on this file, and you'll see lots of errors and warnings,
> but pure codingstyle cleanup is rarely worth anything, so better don't do
> that.
I am sorry, I have not got your meaning clearly.
>
> > Thanks.
> > Best Regards.
> > Harry Wei.
> >
> > Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> > ---
> > scripts/kconfig/gconf.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> > index 4558961..56da945 100644
> > --- a/scripts/kconfig/gconf.c
> > +++ b/scripts/kconfig/gconf.c
> > @@ -7,7 +7,7 @@
> > */
> >
> > #ifdef HAVE_CONFIG_H
> > -# include <config.h>
> > +#include <config.h>
> > #endif
> >
> > #include "lkc.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2011-03-23 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-22 14:38 [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c Harry Wei
2011-03-23 1:28 ` Li Zefan
2011-03-23 7:00 ` Harry Wei [this message]
2011-03-23 7:32 ` Li Zefan
[not found] ` <AANLkTik9tv7Qroin6TucgK5HnY8JOhUuTg8uk4PugC0c@mail.gmail.com>
2011-03-23 12:27 ` Harry Wei
2011-03-23 7:32 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323070017.GA3731@gmail.com \
--to=jiaweiwei.xiyou@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.